Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Turns on Postgres schema drift #3458

Open
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Open

Turns on Postgres schema drift #3458

wants to merge 2 commits into from

Conversation

alishakawaguchi
Copy link
Contributor

@alishakawaguchi alishakawaguchi commented Apr 3, 2025 •
edited
Loading

Fixes NEOS-1741

@alishakawaguchi alishakawaguchi added the enhancement New feature or request label Apr 3, 2025
@alishakawaguchi alishakawaguchi self-assigned this Apr 3, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Apr 3, 2025 8:13pm

@codecov Codecov
Copy link

codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 24.04%. Comparing base (8d0e5ac) to head (0e4e19d).

Files with missing lines Patch % Lines
worker/pkg/workflows/datasync/workflow/workflow.go 0.00% 4 Missing ⚠️
...g/workflows/datasync/workflow/register/register.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3458      +/-   ##
==========================================
- Coverage   24.05%   24.04%   -0.01%     
==========================================
  Files         421      421              
  Lines       56234    56220      -14     
==========================================
- Hits        13526    13520       -6     
+ Misses      41526    41519       -7     
+ Partials     1182     1181       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

Benchstat Geomean Results

0.45% sec/op, 0.01% B/op, -0.35% allocs/op

Benchstat results 
                                                                 │ main-benchmark.txt │       branch-benchmark.txt        │
                                                                 │       sec/op       │   sec/op     vs base              │
CleanPostgresType-4                                                      42.66n ±  9%   42.50n ± 8%       ~ (p=0.584 n=6)
CleanMysqlType-4                                                         53.94n ±  0%   54.72n ± 1%  +1.45% (p=0.011 n=6)
Runner_Single-4                                                          7.701µ ±  3%   7.674µ ± 5%       ~ (p=0.818 n=6)
GenerateBool-4                                                           11.54n ±  1%   11.64n ± 2%  +0.87% (p=0.039 n=6)
GenerateBusinessName-4                                                   304.1n ±  9%   330.3n ± 7%  +8.62% (p=0.041 n=6)
GenerateCardNumber-4                                                     28.96n ±  6%   28.89n ± 0%       ~ (p=0.061 n=6)
GenerateCategorical-4                                                    93.68n ±  1%   94.43n ± 1%  +0.80% (p=0.026 n=6)
GenerateCity-4                                                           173.3n ±  2%   175.9n ± 1%       ~ (p=0.065 n=6)
GenerateCountry-4                                                        95.17n ±  2%   95.67n ± 0%       ~ (p=0.394 n=6)
GenerateEmail-4                                                          1.309µ ±  2%   1.310µ ± 1%       ~ (p=0.494 n=6)
GenerateFirstName-4                                                      203.3n ±  0%   204.5n ± 1%       ~ (p=0.169 n=6)
GenerateFloat64-4                                                        26.39n ±  1%   26.71n ± 2%  +1.21% (p=0.026 n=6)
GenerateFullAddress-4                                                    1.411µ ±  0%   1.423µ ± 0%  +0.92% (p=0.002 n=6)
GenerateFullName-4                                                       1.204µ ±  2%   1.292µ ± 3%  +7.35% (p=0.002 n=6)
GenerateGender-4                                                         36.69n ±  0%   37.09n ± 6%  +1.09% (p=0.002 n=6)
GenerateInt64-4                                                          27.02n ±  0%   27.22n ± 0%  +0.74% (p=0.002 n=6)
GenerateInt64PhoneNumber-4                                               51.15n ±  0%   51.41n ± 0%  +0.51% (p=0.009 n=6)
GenerateInternationalPhoneNumber-4                                       174.2n ±  0%   172.8n ± 3%       ~ (p=0.368 n=6)
GenerateIpAddress-4                                                      560.0n ±  2%   510.9n ± 1%  -8.77% (p=0.002 n=6)
GenerateLastName-4                                                       189.2n ±  1%   192.0n ± 2%  +1.45% (p=0.013 n=6)
GenerateRandomString-4                                                   264.9n ± 24%   267.2n ± 1%       ~ (p=0.258 n=6)
GenerateSHA256Hash-4                                                    1003.5n ±  1%   987.9n ± 1%  -1.55% (p=0.004 n=6)
GenerateSSN-4                                                            265.8n ±  3%   271.3n ± 0%       ~ (p=0.058 n=6)
GenerateState-4                                                          94.77n ±  2%   95.92n ± 3%       ~ (p=0.121 n=6)
GenerateStreetAddress-4                                                  207.5n ±  1%   207.8n ± 1%       ~ (p=0.511 n=6)
GenerateStringPhoneNumber-4                                              171.1n ±  0%   161.2n ± 0%  -5.79% (p=0.002 n=6)
GenerateUnixTimestamp-4                                                  77.04n ±  1%   77.09n ± 1%       ~ (p=0.937 n=6)
GenerateUsername-4                                                       346.1n ±  2%   363.5n ± 2%  +5.06% (p=0.002 n=6)
GenerateUTCTimestamp-4                                                  105.80n ±  1%   99.51n ± 0%  -5.95% (p=0.002 n=6)
GenerateUUID-4                                                           732.1n ±  1%   734.9n ± 0%       ~ (p=0.310 n=6)
GenerateZipcode-4                                                        93.42n ±  1%   94.15n ± 1%  +0.79% (p=0.041 n=6)
TransformCharacterScramble-4                                             159.9n ±  3%   162.4n ± 1%       ~ (p=0.058 n=6)
TransformE164PhoneNumber-4                                               171.6n ±  0%   171.0n ± 2%       ~ (p=0.074 n=6)
TransformEmail-4                                                         1.774µ ±  1%   1.731µ ± 0%  -2.42% (p=0.002 n=6)
TransformFirstName-4                                                     233.9n ±  1%   238.3n ± 1%  +1.86% (p=0.002 n=6)
TransformFloat64-4                                                       101.2n ±  1%   102.1n ± 1%  +0.84% (p=0.039 n=6)
TransformFullName-4                                                      1.236µ ±  2%   1.276µ ± 4%  +3.20% (p=0.002 n=6)
TransformInt64-4                                                         31.92n ±  2%   31.94n ± 0%       ~ (p=0.452 n=6)
TransformInt64PhoneNumber-4                                              57.88n ±  3%   58.56n ± 1%       ~ (p=0.310 n=6)
TransformLastName-4                                                      194.8n ±  1%   197.1n ± 1%  +1.18% (p=0.026 n=6)
TransformString-4                                                        291.5n ±  1%   295.9n ± 0%  +1.51% (p=0.002 n=6)
TransformStringPhoneNumber-4                                             198.8n ±  1%   187.4n ± 0%  -5.73% (p=0.002 n=6)
TransformUuid-4                                                          32.34n ±  0%   32.66n ± 1%  +1.00% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4                82.86n ±  0%   82.64n ± 0%  -0.26% (p=0.026 n=6)
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4             259.2n ±  3%   258.5n ± 3%       ~ (p=0.165 n=6)
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4            1.882µ ±  0%   1.878µ ± 2%       ~ (p=0.589 n=6)
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4              199.7n ±  0%   199.9n ± 1%       ~ (p=0.474 n=6)
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                 3.736n ±  2%   3.736n ± 0%       ~ (p=0.978 n=6)
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                   14.95µ ±  0%   15.42µ ± 2%  +3.12% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4            14.95µ ±  2%   15.47µ ± 1%  +3.53% (p=0.002 n=6)
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4         26.66µ ±  1%   26.82µ ± 2%       ~ (p=0.310 n=6)
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4              26.59µ ±  1%   26.69µ ± 1%       ~ (p=0.093 n=6)
geomean                                                                  240.5n         241.5n       +0.45%

                                                                 │ main-benchmark.txt │         branch-benchmark.txt         │
                                                                 │        B/op        │     B/op      vs base                │
CleanPostgresType-4                                                      0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
CleanMysqlType-4                                                         0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                                                        2.290Ki ± 1%     2.298Ki ± 1%       ~ (p=0.310 n=6)
GenerateBool-4                                                           0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                                                   304.0 ± 0%       304.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                                                     8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                                                    64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                                                           160.0 ± 0%       160.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                                                        24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                                                          385.0 ± 0%       385.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                                                      208.0 ± 0%       208.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                                                        8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                                                    512.0 ± 0%       512.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                                                       418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                                                         16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                                                          7.000 ± 0%       7.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                                               8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4                                       40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                                                      31.00 ± 0%       31.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                                                       176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                                                   72.00 ± 0%       72.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                                                     288.0 ± 0%       288.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                                                            46.00 ± 0%       46.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateState-4                                                          24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                                                  240.0 ± 0%       240.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                                              40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                                                  8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                                                       205.0 ± 0%       205.0 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                                                   24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                                                           80.00 ± 0%       80.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                                                        24.00 ± 0%       24.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4                                             40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformE164PhoneNumber-4                                               40.00 ± 0%       40.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                                                         489.0 ± 0%       489.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                                                     224.0 ± 0%       224.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                                                       88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                                                      418.0 ± 0%       418.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                                                         8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                                              8.000 ± 0%       8.000 ± 0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                                                      176.0 ± 0%       176.0 ± 0%       ~ (p=1.000 n=6) ¹
TransformString-4                                                        88.00 ± 0%       88.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4                                             56.00 ± 0%       56.00 ± 0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                                                          16.00 ± 0%       16.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4                6.000 ± 0%       6.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4             61.00 ± 0%       61.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4            582.0 ± 0%       582.0 ± 0%       ~ (p=1.000 n=6)
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4              64.00 ± 0%       64.00 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                 0.000 ± 0%       0.000 ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                 34.43Ki ± 0%     34.41Ki ± 0%       ~ (p=0.937 n=6)
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4          34.44Ki ± 0%     34.44Ki ± 0%       ~ (p=0.851 n=6)
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4       64.00Ki ± 0%     64.00Ki ± 0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4            64.00Ki ± 0%     64.00Ki ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                                             ²                 +0.01%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                                                 │ main-benchmark.txt │        branch-benchmark.txt         │
                                                                 │     allocs/op      │  allocs/op   vs base                │
CleanPostgresType-4                                                     0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
CleanMysqlType-4                                                        0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
Runner_Single-4                                                         24.00 ±  0%     24.00 ±  0%       ~ (p=1.000 n=6) ¹
GenerateBool-4                                                          0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateBusinessName-4                                                  2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCardNumber-4                                                    1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCategorical-4                                                   2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCity-4                                                          2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateCountry-4                                                       2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateEmail-4                                                         8.000 ±  0%     8.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFirstName-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFloat64-4                                                       1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFullAddress-4                                                   10.00 ±  0%     10.00 ±  0%       ~ (p=1.000 n=6) ¹
GenerateFullName-4                                                      6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateGender-4                                                        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInt64-4                                                         0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInt64PhoneNumber-4                                              1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateInternationalPhoneNumber-4                                      3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateIpAddress-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateLastName-4                                                      2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomString-4                                                  2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateSHA256Hash-4                                                    7.000 ±  0%     7.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateSSN-4                                                           3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateState-4                                                         2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateStreetAddress-4                                                 2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateStringPhoneNumber-4                                             3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUnixTimestamp-4                                                 1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUsername-4                                                      6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUTCTimestamp-4                                                  1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateUUID-4                                                          3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateZipcode-4                                                       2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformCharacterScramble-4                                            3.000 ± 33%     2.500 ± 20%       ~ (p=0.545 n=6)
TransformE164PhoneNumber-4                                              3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformEmail-4                                                        14.00 ±  0%     14.00 ±  0%       ~ (p=1.000 n=6) ¹
TransformFirstName-4                                                    3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformFloat64-4                                                      3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformFullName-4                                                     6.000 ±  0%     6.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformInt64-4                                                        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformInt64PhoneNumber-4                                             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformLastName-4                                                     2.000 ±  0%     2.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformString-4                                                       3.000 ±  0%     3.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformStringPhoneNumber-4                                            4.000 ±  0%     4.000 ±  0%       ~ (p=1.000 n=6) ¹
TransformUuid-4                                                         1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/SmallRange_1_10-4               1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MediumRange_10_100-4            1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/LargeRange_100_1000-4           1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/FixedLength_50_50-4             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/ZeroLength_0_0-4                0.000 ±  0%     0.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/Text_1_65535-4                  1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/AboveLimit_1_100000-4           1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/FixedAboveLimit_100000-4        1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
GenerateRandomStringWithInclusiveBounds/MaxTextSize_65535-4             1.000 ±  0%     1.000 ±  0%       ~ (p=1.000 n=6) ¹
geomean                                                                             ²                -0.35%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

@linear Linear
Copy link

linear bot commented Apr 8, 2025

NEOS-1741 postgres custom sequences SQL returning sequences created by tables

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alishakawaguchi alishakawaguchi

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alishakawaguchi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.