Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix(owner): bypass cache when fetching packument#4565

Merged
nlf merged 1 commit intolatestnpm/cli:latestfrom
gar/owner-cachenpm/cli:gar/owner-cacheCopy head branch name to clipboard
Mar 15, 2022
Merged

fix(owner): bypass cache when fetching packument#4565
nlf merged 1 commit intolatestnpm/cli:latestfrom
gar/owner-cachenpm/cli:gar/owner-cacheCopy head branch name to clipboard

Conversation

@wraithgar
Copy link
Copy Markdown
Member

@wraithgar wraithgar commented Mar 15, 2022 •
edited
Loading

If folks are doing multiple owner commands in succession this can cause the second run to overwrite the first.

@wraithgar wraithgar requested a review from a team as a code owner March 15, 2022 14:41
@npm-robot
Copy link
Copy Markdown
Contributor

npm-robot commented Mar 15, 2022 •
edited
Loading

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 61.796 ±0.61 33.199 ±0.25 19.713 ±0.10 22.079 ±0.64 3.330 ±0.02 3.353 ±0.04 2.718 ±0.05 12.725 ±0.02 2.669 ±0.04 3.808 ±0.08
#4565 60.323 ±3.75 33.079 ±0.10 19.618 ±0.06 22.289 ±0.24 3.375 ±0.05 3.369 ±0.01 2.696 ±0.04 12.851 ±0.03 2.707 ±0.02 3.841 ±0.13
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 39.619 ±0.32 25.413 ±0.06 14.320 ±0.06 15.608 ±0.06 3.015 ±0.01 3.068 ±0.02 2.681 ±0.01 9.466 ±0.02 2.532 ±0.00 3.438 ±0.03
#4565 40.352 ±1.96 26.025 ±0.09 14.547 ±0.10 15.641 ±0.11 3.026 ±0.02 3.066 ±0.02 2.741 ±0.06 9.553 ±0.09 2.529 ±0.02 3.527 ±0.08

nlf
nlf approved these changes Mar 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should definitely help

@nlf nlf merged commit f66da2e into latest Mar 15, 2022
@nlf nlf deleted the gar/owner-cache branch March 15, 2022 18:12
@nlf nlf mentioned this pull request Mar 17, 2022
Merged
@npm-robot npm-robot mentioned this pull request Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nlf nlf nlf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wraithgar @npm-robot @nlf
Morty Proxy This is a proxified and sanitized view of the page, visit original site.