Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix NullReferenceException when disposing transactions (race conditon (?)) #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roji merged 1 commit into from
Apr 6, 2015
Merged

Fix NullReferenceException when disposing transactions (race conditon (?)) #573

roji merged 1 commit into from
Apr 6, 2015

Conversation

@havard
Copy link

@havard havard commented Apr 6, 2015

When running in a relatively heavy load scenario, Npgsql will occasionally (very rarely) fail when disposing transactions that aborted prematurely. I am unable to reproduce the issue consistently, but have a patch which (I think) fixes the problem.

When this exception occurs the logged stack trace I am seeing is this:

An exception of type System.NullReferenceException was thrown: Object reference not set to an instance of an object. 
Stack trace: 
  at Npgsql.NpgsqlTransaction.Dispose(Boolean disposing) 
  at System.Data.Common.DbTransaction.Dispose()
  at System.Data.Entity.Infrastructure.Interception.DbTransactionDispatcher.b__12(DbTransaction t, DbTransactionInterceptionContext c) 
  at System.Data.Entity.Infrastructure.Interception.InternalDispatcher`1.Dispatch[TTarget,TInterceptionContext](TTarget target, Action`2 operation, TInterceptionContext interceptionContext, Action`3 executing, Action`3 executed)
  at System.Data.Entity.Infrastructure.Interception.DbTransactionDispatcher.Dispose(DbTransaction transaction, DbInterceptionContext interceptionContext) 
  at System.Data.Entity.Core.EntityClient.EntityTransaction.Dispose(Boolean disposing) at System.Data.Common.DbTransaction.Dispose() 
  at System.Data.Entity.Core.Objects.ObjectContext.d__3d`1.MoveNext()

This pull request guards against NpgsqlConnector references being null. I cannot be certain that the connector reference is the culprit, but since running with the patch in place I have not observed any more NullReferenceExceptions.

roji added a commit that referenced this pull request Apr 6, 2015
@roji
Merge pull request #573 from havard/2.2
9bbb1f2 
Fix NullReferenceException when disposing transactions (race conditon (?))
@roji roji merged commit 9bbb1f2 into npgsql:2.2 Apr 6, 2015
@roji roji added this to the 2.2.6 milestone Apr 6, 2015
@roji roji added the bug label Apr 6, 2015
@roji
Copy link
Member

roji commented Apr 6, 2015

Thanks for submitting this. Like many others this area of the code has undergone a lot of change in our master branch for the upcoming v3 release. I worked hard to clean up several state issues in master but I can't be sure some aren't left.

If you have any spare time, it would be great if you could give our master branch a spin and report on the results...

@havard
Copy link
Author

havard commented Apr 6, 2015

Thanks for pulling. I will try to find time to give master a spin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.2.6

Development

Successfully merging this pull request may close these issues.

2 participants

@havard @roji
Morty Proxy This is a proxified and sanitized view of the page, visit original site.