Leak removal: Set BaseStream to null when closing connections. #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
added a commit
that referenced
this pull request
Mar 2, 2015
Leak removal: Set BaseStream to null when closing connections.
Member
|
Thanks for this, once again. I have forward-ported this to master as well. A bit out of curiosity: did you actually experience a leak because of this? If so, I'm wondering if it is the result of the cyclical references (between NpgsqlConnector and NpgsqlNetworkStream), or if NpgsqlConnector was still being referenced after being closed (e.g. by the pool). If it's the latter then we probably have another leak somewhere, if it's a matter of cyclical references I was under the impression that the garbage collector knows how to deal with this kind of case... |
Author
|
This was also found in the same analysis I posted earlier, so yes, it is very likely a result of the cyclic references discussed in #505. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #505 identified several cases of resource starvation. This commit fixes leaking NpgsqlBaseStream instances.