Performance improvement #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing in Postgresql logs. For more information check out: http://fxjr.blogspot.com/2011/12/fixed-log-unexpected-eof-on-client.html
Added bug tests Added initial massive datatype testcase.
DateTimeOffset or DateTime. Thanks Misha Sugakov for patch and
testing.
Created lookup array for byte indexes. Byte array populated from that lookup.
External libraries can ask for conversion to Postgres representation
Author
|
Oh, well |
Changes: 2012-01-12 16:44 fxjr * src/: Npgsql/Cache.cs, Npgsql/NpgsqlCommand.cs, Npgsql/NpgsqlCommandBuilder.cs, Npgsql/NpgsqlConnector.cs, Npgsql/NpgsqlConnectorPool.cs, Npgsql/NpgsqlState.cs, Npgsql/PGUtil.cs, NpgsqlTypes/BitString.cs: Applied Gildas Prime patch with Gendarme report corrections: Avoid concatenating chars rule ( i.e Unneeded boxing) A recursive method was found (Method remove in NpgsqlParameterCollection) Disposable fields should be disposed Do not lock on this ( lock(this) makes very difficult to ensure that the locking is done correctly.) Ensure that local variables are disposed surrounding them by using() 2012-01-10 01:14 fxjr * src/Npgsql/NpgsqlConnectorPool.cs: Fixed tabulation. 2012-01-09 12:48 fxjr * src/Npgsql/NpgsqlConnectorPool.cs: Fix [#1011138] Connection pooling performance suffers under heavy load. Rewritten connector pool logic in order to keep lock for much less time and also with a higher granularity. Thanks Andrew for heads up.
…ERIALIZABLE. Thanks Randy Ficker for heads up and patch. Npgsql wasn't honoring the repeatable read isolation level request. This used to work until 9.1 version.
* src/Npgsql/SqlGenerators/: SqlBaseGenerator.cs, VisitedExpression.cs: Fix Include combined with Skip and/or Take using linq to entities for bug #1011208 2012-06-06 11:25 fxjr * src/Npgsql/NpgsqlClosedState.cs: [#1011200] Uses API not supported in MonoTouch. Also fixes https://bugzilla.xamarin.com/show_bug.cgi?id=4992 Npgsql2.0.11 Is not working on MonoTouch. Thanks Sebastien for heads up and all others for helping with this issue. 2012-03-23 09:45 fxjr * src/Npgsql/NpgsqlCommand.cs: [#1011161] Bug in NpgsqlCommand while getting readers from refcursors. Thanks Rabin Karki for heads up and patch. 2012-03-11 22:59 fxjr * src/Npgsql/NpgsqlTransaction.cs: [#1011174] Requesting the REPEATABLE READ isolation level gives you SERIALIZABLE. Thanks Randy Ficker for heads up and patch. Npgsql wasn't honoring the repeatable read isolation level request. This used to work until 9.1 version.
Detect broken connection on Postgres sync notification. Change connetion state to enable recovery.
Fixing chaos in code. Tabs and spaces. Meaningfull folders. Grouping functionality.
Since Nullable<> are not listed in type mappings, check for container type.
Member
|
Hi! Sorry, I didn't check your pull request yet. I'll check it and will let you know if I have any comments. Thank you for your support! |
Removed unnecessary string to StringBuilder conversion. For long strings use GetByteCount to evade OutOfMemoryException
new NpgsqlConnection(string) is slow. Redirect clone to new private constructor which uses NpgsqlConnectionStringBuilder instead of string. Since DbConnectionStringBuilder Clear is slow too, reuse NpgsqlConnectionStringBuilder. NpgsqlConnectionStringBuilder can change in ChangeDatabase, so Clone it there. Optimized LogConnectionString() Skip looping if logging is disabled.
Manage memory to avoid fragmentation.
Error handling for 9.3 Open, Closed events
sr.Read would return 0 as end of stream, but pos did not advanced enough. Probably unicode characted appeared which advanced 2 bytes, but only 1 char.
Added Stream constructor to command for large commands.
There are some strange rules for UTF conversion and let's not reproduce them.
Allow for :: conversion to actual type
Single initialization query. Moved if out of loop. Swallow unknown error. TODO: fix IsValid logic. This takes most of the time in stressed applications.
State should not throw exception. If connection is disposed return Closed state. Update of Mono.Security since previous one doesn't work on Mono
Thread.Sleep(0) doesn't quite work on Linux.
String was incorrectly escaped for \ as \\. This requires E prefix which is not used. Hack to fix conversion, parameter is still wrong.
0b35ef0 to
c43b6af
Compare
e1d8c57 to
1f140e5
Compare
1236d1f to
e8ae2e0
Compare
2fc8944 to
3eb6fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created lookup array for byte indexes.
Byte array populated from that lookup.