Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

mapi-ng
Copy link

@mapi-ng mapi-ng commented Apr 12, 2019

This pull request introduces the following changes:

  • possibility to set a path to directory where files should be dumped,
  • parameter to choose if the reference cloud should be dumped only the first time.

Please let me know what do you think.

Best regards, Marcin Pilch

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@simonpierredeschenes
Copy link
Collaborator

ok to test

@pomerlef
Copy link
Collaborator

pomerlef commented Jul 6, 2021

@simonpierredeschenes can you validate if this PR is ready to merge?

Copy link
Collaborator

@pomerlef pomerlef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small modification to apply

*~
*.swp
*.cur_trans
*.vtk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have .vtk files in /examples/data ignoring this extension could cause problems

@boxanm boxanm changed the base branch from master to develop November 4, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.