add ncc to existing SEA solutions#124
Open
iamstarkov wants to merge 1 commit intonodejs:mainnodejs/single-executable:mainfrom
Open
add ncc to existing SEA solutions#124iamstarkov wants to merge 1 commit intonodejs:mainnodejs/single-executable:mainfrom
iamstarkov wants to merge 1 commit intonodejs:mainnodejs/single-executable:mainfrom
Conversation
Member
|
SEA implies single executable which would include the node binary. I don't think ncc qualifies since its emitting plain JS just like every other bundler, not an executable. See my list if you want existing SEA tools https://github.com/styfle/awesome-desktop-js/blob/main/README.md#packaging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ncc is recommended by GitHub to compile js GitHub Actions into a single file https://docs.github.com/en/actions/tutorials/create-actions/create-a-javascript-action#commit-tag-and-push-your-action
my main point of contact in the repository is @styfle. im not sure what this point of contact fields mean, so depending on that @styfle may not consent to being mentioned here