Fix string_decoder import#548
Merged
MattiasBuelens merged 5 commits intonodejs:mainnodejs/readable-stream:mainfrom Dec 31, 2024
Merged
Fix string_decoder import#548MattiasBuelens merged 5 commits intonodejs:mainnodejs/readable-stream:mainfrom
string_decoder import#548MattiasBuelens merged 5 commits intonodejs:mainnodejs/readable-stream:mainfrom
Conversation
Resolves nodejs#547
MattiasBuelens
requested changes
Dec 31, 2024
Merged
Member
|
I see a lot of formatting changes. Why are those in? |
Contributor
|
@mcollina That's just the result of We should really have CI check that for us. I'll make a PR afterwards to run both Prettier and ESLint on CI. |
MattiasBuelens
approved these changes
Dec 31, 2024
Contributor
Author
|
Thanks for reviewing @mcollina @MattiasBuelens . I do not have write access to this repository so one of you will need to perform the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #547
Have tested this fix in a vercel edge environment