Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use globalThis instead of global#530

Merged
mcollina merged 2 commits intomainnodejs/readable-stream:mainfrom
globalthisnodejs/readable-stream:globalthisCopy head branch name to clipboard
Dec 18, 2023
Merged

Use globalThis instead of global#530
mcollina merged 2 commits intomainnodejs/readable-stream:mainfrom
globalthisnodejs/readable-stream:globalthisCopy head branch name to clipboard

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Dec 18, 2023

Fixes #529

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mofux
Copy link

mofux commented Dec 18, 2023

There's also another occurence in src/util.js:

const AbortSignal = global.AbortSignal || require('abort-controller').AbortSignal
const AbortController = global.AbortController || require('abort-controller').AbortController

However, not sure if this one also needs modification.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v4.5.0: global is not defined

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.