Wrap security so it respects Node.js linter #2610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't matter here, but to keep this file textually identical to the policy in Node.js, the markdown needs to lint clean. See: nodejs/node#29682
richardlau
approved these changes
Sep 26, 2019
Member
richardlau
left a comment
There was a problem hiding this comment.
Two small non-blocking nits.
Member
FWIW, I think the plan is to eventually have the same markdown linting rules in both repositories, so this is a good thing to do now. |
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't matter here, but to keep this file textually identical to the
policy in Node.js, the markdown needs to lint clean.
See: nodejs/node#29682