Experimental node_api_nogc_env is not stripped

Ref:

node-api-headers/include/js_native_api_types.h

Lines 46 to 53 in 1294543

    
           #if !defined(NAPI_EXPERIMENTAL) ||                                             \ 
        
               (defined(NAPI_EXPERIMENTAL) &&                                             \ 
        
                (defined(NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT) ||                       \ 
        
                 defined(NODE_API_EXPERIMENTAL_BASIC_ENV_OPT_OUT))) 
        
           typedef struct napi_env__* node_api_nogc_env; 
        
           #else 
        
           typedef const struct napi_env__* node_api_nogc_env; 
        
           #endif

All other NAPI_EXPERIMENTAL apis were stripped, but node_api_nogc_env and node_api_nogc_finalize were not.

If NAPI_EXPERIMENTAL is defined, node_api_post_finalizer is missing for node_api_nogc_finalize callbacks.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Experimental `node_api_nogc_env` is not stripped #51

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	#if !defined(NAPI_EXPERIMENTAL) \|\| \
	(defined(NAPI_EXPERIMENTAL) && \
	(defined(NODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT) \|\| \
	defined(NODE_API_EXPERIMENTAL_BASIC_ENV_OPT_OUT)))
	typedef struct napi_env__* node_api_nogc_env;
	#else
	typedef const struct napi_env__* node_api_nogc_env;
	#endif

Search code, repositories, users, issues, pull requests...

Uh oh!

Experimental node_api_nogc_env is not stripped #51

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Experimental `node_api_nogc_env` is not stripped #51