Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Change var to const or let in test-child-process-ipc.js #9990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malenesok007 wants to merge 1 commit into from
Closed

Change var to const or let in test-child-process-ipc.js #9990

malenesok007 wants to merge 1 commit into from

Conversation

@malenesok007
Copy link
Contributor

@malenesok007 malenesok007 commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@imyller
Copy link
Member

imyller commented Dec 1, 2016

@malenesok007 May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
@malenesok007
Copy link
Contributor Author

malenesok007 commented Dec 1, 2016

Hi I have modify the commit message. Is there something I am missing? Thanks.

cjihrig
cjihrig approved these changes Dec 5, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI.

@Trott
Copy link
Member

Trott commented Dec 8, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5326/

silverwind
silverwind suggested changes Dec 9, 2016
View reviewed changes
test/parallel/test-child-process-ipc.js Outdated
Copy link
Contributor

@silverwind silverwind Dec 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter error here:

 error  'child' is never reassigned. Use 'const' instead  prefer-const

@Trott
Copy link
Member

Trott commented Dec 22, 2016

Ping @malenesok007: Can you change the let to const as identified in the comment from @silverwind? You can run make jslint (or, if on Windows, vcbuild jslint nosign I think) to check for other lint errors before pushing.

@Trott
Copy link
Member

Trott commented Dec 24, 2016

Because it was a straightforward lint fix, I made the change and pushed it to @malenesok007's branch.

@silverwind Can you take a look and, if appropriate, update your review? Thanks!

@Trott
Copy link
Member

Trott commented Dec 24, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5568/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 24, 2016
@malenesok007 @Trott
test: refactor test-child-process-ipc
ff88a5a 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: nodejs#9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@Trott
Copy link
Member

Trott commented Dec 24, 2016

Landed in ff88a5a.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 24, 2016
targos pushed a commit that referenced this pull request Dec 26, 2016
@malenesok007 @targos
test: refactor test-child-process-ipc
610ec55 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Dec 27, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
@malenesok007 @targos
test: refactor test-child-process-ipc
16460e9 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@malenesok007 @evanlucas
test: refactor test-child-process-ipc
c2b525a 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@malenesok007 @evanlucas
test: refactor test-child-process-ipc
599a2a9 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@malenesok007 @MylesBorins
test: refactor test-child-process-ipc
c074982 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@malenesok007 @MylesBorins
test: refactor test-child-process-ipc
3ffd4d6 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
@malenesok007 @MylesBorins
test: refactor test-child-process-ipc
4efdbaf 
Change var to const or let.
Change assert.equal() to assert.strictEqual().

PR-URL: #9990
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@silverwind silverwind silverwind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@malenesok007 @imyller @Trott @silverwind @jasnell @cjihrig @mscdex @targos @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.