Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@likhter
Copy link

@likhter likhter commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Changed assert.equal() to assert.strictEqual() in test/parallel/test-dgram-send-multi-buffer-copy.js

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 1, 2016

@likhter
Copy link
Author

likhter commented Dec 3, 2016

I suppose CI failures are unrelated

@Trott
Copy link
Member

Trott commented Dec 3, 2016

I suppose CI failures are unrelated

The CI job was manually terminated along with several others. I'll re-run it now.

CI: https://ci.nodejs.org/job/node-test-pull-request/5138/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2016
assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 5, 2016

Landed in f13047d.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
assert.equal() -> assert.strictEqual()

PR-URL: #9909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
assert.equal() -> assert.strictEqual()

PR-URL: nodejs#9909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
assert.equal() -> assert.strictEqual()

PR-URL: #9909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.