update test/parallel/test-fs-read-stream-inherit.js to use ES6 variable declarations and assert.strictEqual #9894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2016 10:13
converts all instances of 'var' to const / let
converts instances of assert.equal to assert.strictEqual
Member
cjihrig
reviewed
Dec 3, 2016
| callbacks.close++; | ||
|
|
||
| //assert.equal(fs.readFileSync(fn), fileContent); | ||
| //assert.strictEqual(fs.readFileSync(fn), fileContent); |
lpinca
reviewed
Dec 3, 2016
| file.length = 0; | ||
| callbacks.open++; | ||
| assert.equal('number', typeof fd); | ||
| assert.strictEqual('number', typeof fd); |
Member
There was a problem hiding this comment.
Nit: can you please swap the arguments here and throughout the rest of the file? The function signature is assert.strictEqual(actual, expected[, message]);
lpinca
approved these changes
Dec 3, 2016
added 2 commits
December 3, 2016 11:56
Removes an assert that has been commented out.
Fixes the parameter order to some calls of assert.strictEqual to be consistent with documentation and the rest of the file.
lpinca
reviewed
Dec 3, 2016
|
|
||
| var file4 = fs.createReadStream(rangeFile, Object.create({bufferSize: 1, | ||
| const file4 = fs.createReadStream(rangeFile, Object.create({bufferSize: 1, | ||
| start: 1, end: 2})); |
Member
There was a problem hiding this comment.
Nit: would you mind to align start with rangeFile?
lpinca
reviewed
Dec 3, 2016
|
|
||
| var file5 = fs.createReadStream(rangeFile, Object.create({bufferSize: 1, | ||
| const file5 = fs.createReadStream(rangeFile, Object.create({bufferSize: 1, | ||
| start: 1})); |
cjihrig
approved these changes
Dec 3, 2016
lpinca
reviewed
Dec 3, 2016
| // https://github.com/joyent/node/issues/2320 | ||
| var file6 = fs.createReadStream(rangeFile, Object.create({bufferSize: 1.23, | ||
| const file6 = fs.createReadStream(rangeFile, Object.create({bufferSize: 1.23, | ||
| start: 1})); |
Member
There was a problem hiding this comment.
Ditto, there are also a couple more below.
Fixes spacing that become improperly alligned after changing var declarations to const.
Member
|
@jmdarling awesome, thank you! |
jasnell
approved these changes
Dec 4, 2016
Member
jasnell
left a comment
There was a problem hiding this comment.
LGTM! thank you for the PR and for participating in the code-and-learn!
jasnell
pushed a commit
that referenced
this pull request
Dec 4, 2016
* convert assert.equal to assert.strictEqual * convert var to const/let PR-URL: #9894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in e00c4bf. thank you! |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
* convert assert.equal to assert.strictEqual * convert var to const/let PR-URL: #9894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* convert assert.equal to assert.strictEqual * convert var to const/let PR-URL: nodejs#9894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* convert assert.equal to assert.strictEqual * convert var to const/let PR-URL: nodejs#9894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
* convert assert.equal to assert.strictEqual * convert var to const/let PR-URL: #9894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* convert assert.equal to assert.strictEqual * convert var to const/let PR-URL: #9894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* convert assert.equal to assert.strictEqual * convert var to const/let PR-URL: #9894 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Updates test/parallel/test-fs-read-stream-inherit.js by: