url: fix -Warray-bounds warning #9751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Nov 23, 2016
Member
bnoordhuis
left a comment
There was a problem hiding this comment.
Ai, obvious bug is obvious. LGTM.
Aside: I fail to understand why it favors hard-coded values over arraysize(host->value.ipv6).
cjihrig
approved these changes
Nov 23, 2016
Member
Author
Avoid out of bounds access to `url_host_value.ipv6` array. PR-URL: nodejs#9751 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Thanks. Landed in 0ab2182 |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Avoid out of bounds access to `url_host_value.ipv6` array. PR-URL: #9751 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Avoid out of bounds access to
url_host_value.ipv6array.