Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

v4.x backport: url: fix inconsistent port in url.resolveObject #8872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
imyller wants to merge 1 commit into from
Closed

v4.x backport: url: fix inconsistent port in url.resolveObject #8872

imyller wants to merge 1 commit into from

Conversation

@imyller
Copy link
Member

@imyller imyller commented Sep 30, 2016

v4.x backport of #8214

/cc @thealphanerd

@imyller
url: fix inconsistent port in url.resolveObject
a0d55cb 
This commit fixes bug where url.resolveObject returns conflicting
host and port values.

Fixes: nodejs#8213
PR-URL: nodejs#8214
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added url Issues and PRs related to the legacy built-in url module. v4.x labels Sep 30, 2016
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@imyller
url: fix inconsistent port in url.resolveObject
2362504 
This commit fixes bug where url.resolveObject returns conflicting
host and port values.

Fixes: #8213
Ref: #8872
PR-URL: #8214
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 30, 2016

landed in 2362504

MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@imyller
url: fix inconsistent port in url.resolveObject
308c8de 
This commit fixes bug where url.resolveObject returns conflicting
host and port values.

Fixes: #8213
Ref: #8872
PR-URL: #8214
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@imyller @rvagg
url: fix inconsistent port in url.resolveObject
2c288a6 
This commit fixes bug where url.resolveObject returns conflicting
host and port values.

Fixes: #8213
Ref: #8872
PR-URL: #8214
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@imyller @MylesBorins
url: fix inconsistent port in url.resolveObject
be9d9bd 
This commit fixes bug where url.resolveObject returns conflicting
host and port values.

Fixes: #8213
Ref: #8872
PR-URL: #8214
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@imyller @MylesBorins @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.