Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

util: support SharedArrayBuffer in inspect #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alistairjcbrown wants to merge 1 commit into from
Closed

util: support SharedArrayBuffer in inspect #8612

alistairjcbrown wants to merge 1 commit into from

Conversation

@alistairjcbrown
Copy link

@alistairjcbrown alistairjcbrown commented Sep 17, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

util

Description of change

Update inspect utility to support readable output of SharedArrayBuffer object. SharedArrayBuffer is available behind the harmony_sharedarraybuffer v8 flag. See the MDN docs for more details on what a SharedArrayBuffer is.

@alistairjcbrown
util: support SharedArrayBuffer in inspect
2856705 
Update inspect utility to support readable output of SharedArrayBuffer
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. util Issues and PRs related to the built-in util module. labels Sep 17, 2016
@yosuke-furukawa
Copy link
Member

yosuke-furukawa commented Sep 17, 2016

I think that would be better to merge my fix... #8587

@Fishrock123
Copy link
Contributor

Fishrock123 commented Sep 17, 2016

Shouldn't we wait for this feature to become publicly available in V8 first?

@alistairjcbrown
Copy link
Author

alistairjcbrown commented Sep 19, 2016

Looks like #8587 has been updated to be nearly the same as this PR (I've added comments on that PR).

The only thing this PR has extra is an update to a comment in test-util-inspect-simd.js to reference the correct test file, and adding an explicit ArrayBuffer test to test-util-inspect.js. I'll leave it open for the meantime, but it can probably be closed as a dupe.

@jasnell
Copy link
Member

jasnell commented Sep 20, 2016

For the time being I'll mark this as being blocked on #8587. Thank you!

@jasnell jasnell added the blocked PRs that are blocked by other issues or PRs. label Sep 20, 2016
@rvagg rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02
@jasnell jasnell removed the blocked PRs that are blocked by other issues or PRs. label Mar 1, 2017
@jasnell
Copy link
Member

jasnell commented Mar 1, 2017

Is this still needed?

@jasnell jasnell added the stalled Issues and PRs that are stalled. label Mar 1, 2017
@TimothyGu
Copy link
Member

TimothyGu commented Mar 1, 2017

Looks like everything except for the inspection test for ArrayBuffer was landed in #8587. Support for SIMD.js was deleted from util.format(). Closing this.

@TimothyGu TimothyGu closed this Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. stalled Issues and PRs that are stalled. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alistairjcbrown @yosuke-furukawa @Fishrock123 @jasnell @TimothyGu @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.