benchmark: Repair http chunked benchmark #7616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benchmark/http/chunked.js
Outdated
| @@ -18,7 +18,7 @@ var bench = common.createBenchmark(main, { | ||
|
|
||
| function main(conf) { | ||
| const http = require('http'); | ||
| var chunk = Buffer.alloc(conf.size, '8'); | ||
| var chunk = Buffer.alloc(Number(conf.size), '8'); |
Contributor
There was a problem hiding this comment.
Could you do +conf.size instead?
Author
There was a problem hiding this comment.
Great. I've amended the previous commit.
Contributor
|
LGTM with a slight comment. |
Contributor
|
LGTM except for the nit raised by @cjihrig |
Cast to number the configuration size before passing it to the buffer constructor. Signed-off-by: Sorin Baltateanu <sorin.baltateanu@intel.com>
Author
|
I have updated the pull request to include the suggested changes. Thanks. |
Contributor
|
Actually, I just realized I fixed this as part of #7311. It would be great if we could get that PR landed as it is more comprehensive. It would be nice to have people add their input on that PR. |
Member
Contributor
|
@jasnell No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
benchmark
Description of change
Cast to number the configuration size before passing it to the buffer constructor.
When running the http chunked benchmark the following exception occurs:
buffer.js:110
throw err;
^
TypeError: "size" argument must be a number
at Function.Buffer.alloc (buffer.js:119:3)
at Benchmark.main as fn
at Benchmark._run (/builds/2016-07-06_02-55-00/node/benchmark/common.js:139:17)
at /builds/2016-07-06_02-55-00/node/benchmark/common.js:96:10
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickCallback (internal/process/next_tick.js:98:9)
at Module.runMain (module.js:577:11)
at run (bootstrap_node.js:340:7)
at startup (bootstrap_node.js:132:9)
at bootstrap_node.js:455:3
Signed-off-by: Sorin Baltateanu sorin.baltateanu@intel.com