lib: replace legacy uses of __defineGetter__ #6768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor clean up. There are still some places in core that use the legacy __defineGetter__ syntax. This updates those.
Member
Author
|
@Trott ... is there an eslint rule that can catch these? |
2 tasks
Member
Not a pre-existing one, but I've made a custom one: #6774 According to that lint rule, there are two files missed in this PR:
I can do them as part of that PR or you can add them to this one. Doesn't matter to me either way. |
Member
Author
|
I have a separate pr that covers the stdio ones. I intentionally did not touch the tests. |
Member
Author
|
@Trott ... does this PR LGTY? |
Member
Author
Member
|
LGTM |
jasnell
added a commit
that referenced
this pull request
May 17, 2016
Minor clean up. There are still some places in core that use the legacy __defineGetter__ syntax. This updates most of those. PR-URL: #6768 Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
Landed in f293d0b |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Minor clean up. There are still some places in core that use the legacy __defineGetter__ syntax. This updates most of those. PR-URL: #6768 Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 18, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 20, 2016
PR-URL: nodejs#6774 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Refs: nodejs#6768
Contributor
|
@jasnell lts? |
Contributor
|
@thealphanerd Little value; I wouldn't bother. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
crypto, readline, internal
Description of change
Minor clean up. There are still some places in core that use the legacy
__defineGetter__syntax. This updates those.