test: deflake test-webcrypto-crypto-job-mode#63543
Merged
Merged
test: deflake test-webcrypto-crypto-job-mode#63543
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63543 +/- ##
==========================================
+ Coverage 90.13% 90.33% +0.20%
==========================================
Files 718 730 +12
Lines 228399 234161 +5762
Branches 42931 43908 +977
==========================================
+ Hits 205860 211522 +5662
- Misses 14283 14366 +83
- Partials 8256 8273 +17 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
approved these changes
May 25, 2026
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
May 25, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
|
Landed in 75c1982 |
aduh95
pushed a commit
that referenced
this pull request
May 27, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #63543 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deflake the test by corrupting the first AES-CBC ciphertext byte instead of the final byte. Mutating the final byte made the decrypted padding block random, which could occasionally produce valid PKCS#7 padding and cause subtle.decrypt() to resolve. Mutating the first byte deterministically corrupts the padding block for this two-block ciphertext, so the expected OperationError rejection is stable.
flake e.g. https://ci.nodejs.org/job/node-test-commit-linuxone/55565/nodes=rhel8-s390x/testReport/junit/(root)/parallel/test_webcrypto_crypto_job_mode/