test: unskip snapshot reproducibility test#63307
Merged
Merged
test: unskip snapshot reproducibility test#63307
Conversation
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63307 +/- ##
==========================================
+ Coverage 90.04% 90.05% +0.01%
==========================================
Files 713 714 +1
Lines 225003 225247 +244
Branches 42536 42584 +48
==========================================
+ Hits 202606 202852 +246
- Misses 14177 14179 +2
+ Partials 8220 8216 -4 🚀 New features to boost your workflow:
|
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
This comment has been minimized.
This comment has been minimized.
Collaborator
panva
approved these changes
May 15, 2026
aduh95
approved these changes
May 15, 2026
sxa
approved these changes
May 15, 2026
sxa
left a comment
Member
There was a problem hiding this comment.
The reproducibility test job hasn't been showing any problems, although it's still configured to build with gcc. Have you been seeing problems pre-14.6?
Either way I'm happy to have this test unskipped :-)
Member
Author
|
It was skipped in #62808 likely because there was a v8 bug that got triggered only on shared builds (this tends to be dependent on the shape the memory graph happen to be), but not on other Linux builds, which was likely fixed in the 14.6 upgrade (probably by https://chromium-review.googlesource.com/c/v8/v8/+/7666243) |
richardlau
approved these changes
May 15, 2026
lpinca
approved these changes
May 15, 2026
Contributor
|
Landed in 61d66c3 |
aduh95
pushed a commit
that referenced
this pull request
May 22, 2026
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #63307 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
araujogui
pushed a commit
to araujogui/node
that referenced
this pull request
May 26, 2026
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: nodejs#63307 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See if the v8 14.6 upgrade has fixed it.
On a side note, debian will require reproducible builds in their packages https://lists.debian.org/debian-devel-announce/2026/05/msg00001.html