Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[24.x] deps: update nghttp2 to 1.69.0#63164

Open
mcollina wants to merge 2 commits into
nodejs:v24.x-stagingnodejs/node:v24.x-stagingfrom
mcollina:nghttp2-main-updates-v24.x-stagingmcollina/node:nghttp2-main-updates-v24.x-stagingCopy head branch name to clipboard
Open

[24.x] deps: update nghttp2 to 1.69.0#63164
mcollina wants to merge 2 commits into
nodejs:v24.x-stagingnodejs/node:v24.x-stagingfrom
mcollina:nghttp2-main-updates-v24.x-stagingmcollina/node:nghttp2-main-updates-v24.x-stagingCopy head branch name to clipboard

Conversation

@mcollina

@mcollina mcollina commented May 7, 2026 •
edited by aduh95
Loading

Copy link
Copy Markdown
Member

@nodejs-github-bot

nodejs-github-bot commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels May 7, 2026
@codecov

codecov Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.91%. Comparing base (b881658) to head (2756a4d).
⚠️ Report is 66 commits behind head on v24.x-staging.

Files with missing lines Patch % Lines
src/node_http2.cc 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           v24.x-staging   #63164      +/-   ##
=================================================
- Coverage          89.92%   89.91%   -0.01%     
=================================================
  Files                686      686              
  Lines             208389   208993     +604     
  Branches           40077    40184     +107     
=================================================
+ Hits              187387   187924     +537     
- Misses             13238    13293      +55     
- Partials            7764     7776      +12
Files with missing lines Coverage Δ
src/node_http2.h 91.61% <ø> (ø)
src/node_http2.cc 81.85% <87.50%> (-0.01%) ⬇️

... and 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina changed the title Nghttp2 main updates v24.x staging [24.x] deps: update nghttp2 to 1.69.0 May 7, 2026
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2026
@nodejs-github-bot

nodejs-github-bot commented May 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73232/

@aduh95

aduh95 commented May 7, 2026

Copy link
Copy Markdown
Contributor

@nodejs/lts how confortable are we to land this on LTS release line given the test changes?

@nodejs-github-bot

nodejs-github-bot commented May 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73239/

@mcollina

mcollina commented May 8, 2026

Copy link
Copy Markdown
Member Author

We need to backport this update due to GHSA-6933-cjhr-5qg6. I assume we don't want to float a patch on top of nghttp2, which also would not please security scanners.

@nodejs-github-bot

nodejs-github-bot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73380/

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2026
@nodejs-github-bot

nodejs-github-bot commented May 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73734/

nodejs-github-bot and others added 2 commits May 27, 2026 17:30
@nodejs-github-bot @aduh95
deps: update nghttp2 to 1.69.0
7fd2f6c 
PR-URL: nodejs#62891
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@pimterry @aduh95
deps: fix integration issues with the latest nghttp2
2756a4d 
This is a set of src & tests fixes for nghttp2 due to changes in
v1.67.0+ which require a selection of changes to how we handle
low-level protocol errors when using the latest versions of nghttp2,
changing both some src error handling and updating some tests to match.

Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#62891
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the nghttp2-main-updates-v24.x-staging branch from 3fb51d5 to 2756a4d Compare May 27, 2026 15:31
@nodejs-github-bot

nodejs-github-bot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73786/

@nodejs-github-bot

nodejs-github-bot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73790/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimterry pimterry pimterry approved these changes

@trivikr trivikr trivikr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mcollina @nodejs-github-bot @aduh95 @pimterry @trivikr @RafaelGSS
Morty Proxy This is a proxified and sanitized view of the page, visit original site.