stream: ensuring cross-destruction in _duplexify to prevent leaks#62824
Merged
Merged
stream: ensuring cross-destruction in _duplexify to prevent leaks#62824
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62824 +/- ##
==========================================
- Coverage 89.69% 89.69% -0.01%
==========================================
Files 706 706
Lines 218222 218222
Branches 41768 41763 -5
==========================================
- Hits 195731 195726 -5
+ Misses 14411 14408 -3
- Partials 8080 8088 +8
🚀 New features to boost your workflow:
|
Collaborator
cola119
approved these changes
Apr 19, 2026
Collaborator
|
Landed in dd85293 |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
PR-URL: #62824 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 7, 2026
PR-URL: #62824 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
araujogui
pushed a commit
to araujogui/node
that referenced
this pull request
May 26, 2026
PR-URL: nodejs#62824 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.