src: fix dead inspector help URL#62802
Closed
galaxy4276 wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
galaxy4276:src/fix-inspector-help-urlgalaxy4276/node:src/fix-inspector-help-urlCopy head branch name to clipboard
Closed
src: fix dead inspector help URL#62802galaxy4276 wants to merge 1 commit intonodejs:mainnodejs/node:mainfrom galaxy4276:src/fix-inspector-help-urlgalaxy4276/node:src/fix-inspector-help-urlCopy head branch name to clipboard
galaxy4276 wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
galaxy4276:src/fix-inspector-help-urlgalaxy4276/node:src/fix-inspector-help-urlCopy head branch name to clipboard
Conversation
The URL printed when running `node --inspect` pointed to https://nodejs.org/en/docs/inspector which returns 404. Update it to https://nodejs.org/api/inspector.html which is the current location of the inspector API documentation. Fixes: nodejs#62743 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Review requested:
|
Member
|
Duplicate of #62745. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62802 +/- ##
==========================================
- Coverage 89.70% 89.69% -0.01%
==========================================
Files 706 706
Lines 218288 218288
Branches 41782 41782
==========================================
- Hits 195806 195798 -8
- Misses 14394 14403 +9
+ Partials 8088 8087 -1
🚀 New features to boost your workflow:
|
Contributor
Author
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running
node --inspect, Node.js prints:This URL returns 404. Update it to the current location of the
inspector API documentation.
Changes
src/inspector_socket_server.cc: replacehttps://nodejs.org/en/docs/inspectorwith
https://nodejs.org/api/inspector.htmlFixes: #62743
Test plan
node --inspect -e ""and verify the printed URL is reachable