Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

tools: fix --shared-ffi compilation on macOS#62737

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
aduh95:fix-shared-ffiaduh95/node:fix-shared-ffiCopy head branch name to clipboard
Apr 14, 2026
Merged

tools: fix --shared-ffi compilation on macOS#62737
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
aduh95:fix-shared-ffiaduh95/node:fix-shared-ffiCopy head branch name to clipboard

Conversation

@aduh95

@aduh95 aduh95 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Refs: #62731 (comment)

The CI didn't catch it because we're explicitely disabling FFI support on macOS test-shared.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 14, 2026
@aduh95 aduh95 added fast-track PRs that do not need to wait for 72 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please πŸ‘ to approve.

@ShogunPanda ShogunPanda added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2026
@aduh95

aduh95 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

CQ is still blocked by nodejs/node-core-utils#1059

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/62737
βœ”  Done loading data for nodejs/node/pull/62737
----------------------------------- PR info ------------------------------------
Title      tools: fix `--shared-ffi` compilation on macOS (#62737)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:fix-shared-ffi -> nodejs:main
Labels     tools, fast-track, author ready
Commits    1
 - tools: fix `--shared-ffi` compilation on macOS
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62737
Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62737
Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Tue, 14 Apr 2026 14:28:50 GMT
   βœ”  Approvals: 4
   βœ”  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/62737#pullrequestreview-4106737238
   βœ”  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/62737#pullrequestreview-4106765490
   βœ”  - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/62737#pullrequestreview-4106767822
   βœ”  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/62737#pullrequestreview-4107107923
   β„Ή  This PR is being fast-tracked
   βœ”  Last GitHub CI successful
   β„Ή  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   βœ”  No git cherry-pick in progress
   βœ”  No git am in progress
   βœ”  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
βœ”  origin/main is now up-to-date
- Downloading patch for 62737
From https://github.com/nodejs/node
 * branch                  refs/pull/62737/merge -> FETCH_HEAD
βœ”  Fetched commits as d0fa608c0796..dd0e66fdfd90
--------------------------------------------------------------------------------
[main be80ce7283] tools: fix `--shared-ffi` compilation on macOS
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Tue Apr 14 16:26:44 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
   βœ”  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
PR-URL: https://github.com/nodejs/node/pull/62737
Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
[main 6061758826] PR-URL: https://github.com/nodejs/node/pull/62737 Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Tue Apr 14 16:26:44 2026 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
  βœ–  60617588265df1bc1e0de9e97e4ea642ddf07a1e
     βœ”  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
     βœ”  0:0      skipping fixes-url                        fixes-url
     βœ–  1:0      blank line expected after title           line-after-title
     βœ”  0:0      line-lengths are valid                    line-length
     βœ”  0:0      metadata is at end of message             metadata-end
     βœ–  0:0      Commit must have a PR-URL.                pr-url
     βœ”  0:0      reviewers are valid                       reviewers
     βœ–  0:0      Invalid subsystem: "PR-URL"               subsystem
     βœ”  0:0      Title is formatted correctly.             title-format
     βœ”  0:0      Title is <= 50 columns.                   title-length
   β„Ή  Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`
https://github.com/nodejs/node/actions/runs/24407872429

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 14, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2026
@nodejs-github-bot nodejs-github-bot merged commit a0160a8 into nodejs:main Apr 14, 2026
43 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a0160a8

@aduh95 aduh95 deleted the fix-shared-ffi branch April 14, 2026 20:16
@ShogunPanda ShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 15, 2026
@addaleax addaleax added the ffi Issues and PRs related to experimental Foreign Function Interface support. label Apr 20, 2026
aduh95 added a commit that referenced this pull request May 5, 2026
PR-URL: #62737
Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 72 hours to land. ffi Issues and PRs related to experimental Foreign Function Interface support. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.