Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fs: add followSymlinks option to glob#62695

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainnodejs/node:mainfrom
mcollina:fs-glob-follow-symlinksmcollina/node:fs-glob-follow-symlinksCopy head branch name to clipboard
Apr 24, 2026
Merged

fs: add followSymlinks option to glob#62695
nodejs-github-bot merged 2 commits into
nodejs:mainnodejs/node:mainfrom
mcollina:fs-glob-follow-symlinksmcollina/node:fs-glob-follow-symlinksCopy head branch name to clipboard

Conversation

@mcollina

Copy link
Copy Markdown
Member

Add a followSymlinks option to fs.glob(), fs.globSync(), and fsPromises.glob(), with tests and docs.

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Apr 11, 2026
@codecov

codecov Bot commented Apr 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.47727% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (449a93a) to head (3a8efcd).
⚠️ Report is 151 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/fs/glob.js 91.47% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62695      +/-   ##
==========================================
+ Coverage   89.78%   89.80%   +0.02%     
==========================================
  Files         697      699       +2     
  Lines      215749   216527     +778     
  Branches    41294    41418     +124     
==========================================
+ Hits       193705   194460     +755     
- Misses      14124    14152      +28     
+ Partials     7920     7915       -5     
Files with missing lines Coverage Δ
lib/internal/fs/glob.js 91.48% <91.47%> (+0.07%) ⬆️

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@mcollina mcollina requested review from MoLow, aduh95 and jasnell April 20, 2026 08:17
@mcollina mcollina added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 22, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2026
@nodejs-github-bot nodejs-github-bot merged commit 4744070 into nodejs:main Apr 24, 2026
71 of 72 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 4744070

aduh95 pushed a commit that referenced this pull request May 5, 2026
PR-URL: #62695
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 7, 2026
PR-URL: #62695
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
araujogui pushed a commit to araujogui/node that referenced this pull request May 26, 2026
PR-URL: nodejs#62695
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.