Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

doc: fix spelling in release announcement guidance#62663

Merged
aduh95 merged 1 commit into
nodejs:mainnodejs/node:mainfrom
Rohan5commit:docs/fix-official-typo-releases-guide-20260410Rohan5commit/node:docs/fix-official-typo-releases-guide-20260410Copy head branch name to clipboard
Apr 10, 2026
Merged

doc: fix spelling in release announcement guidance#62663
aduh95 merged 1 commit into
nodejs:mainnodejs/node:mainfrom
Rohan5commit:docs/fix-official-typo-releases-guide-20260410Rohan5commit/node:docs/fix-official-typo-releases-guide-20260410Copy head branch name to clipboard

Conversation

@Rohan5commit

Copy link
Copy Markdown
Contributor

Summary

  • Fixes a spelling typo in contributor documentation.
  • Changes offical to official in doc/contributing/releases.md.

Related issue

N/A (trivial docs typo fix)

Guideline alignment

  • One focused change in one file.
  • No behavior changes.
  • Commit includes DCO sign-off.

Validation

  • Not run (documentation-only change).

Signed-off-by: Codex <codex@openai.com>
Copilot AI review requested due to automatic review settings April 10, 2026 02:22
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a typo in the release announcement contributor documentation, improving clarity in the “Announce” section of the release process guidance.

Changes:

  • Corrects officalofficial in release announcement guidance text.
  • Updates the affected Markdown line (including leading whitespace) in the “Announce” section.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1126 to +1127
To announce the build on social media, please ping the @nodejs-social-team
on offical slack channel.
on official slack channel.

Copilot AI Apr 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider capitalizing “Slack” for consistency with other parts of this document (e.g., later sections refer to “Slack channel”). Also, the sentence reads more naturally as “on the official Slack channel.”

Copilot uses AI. Check for mistakes.
Comment on lines 1126 to +1127
To announce the build on social media, please ping the @nodejs-social-team
on offical slack channel.
on official slack channel.

Copilot AI Apr 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also removes leading indentation before the continuation line. In Markdown, indentation can change rendering (e.g., turning text into a code block). If the intent is only a spelling fix, consider either keeping the original indentation or updating the PR description to reflect the formatting change.

Copilot uses AI. Check for mistakes.
@aduh95 aduh95 added fast-track PRs that do not need to wait for 72 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 merged commit 4c4c9e7 into nodejs:main Apr 10, 2026
31 of 32 checks passed
@aduh95

aduh95 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Landed in 4c4c9e7

aduh95 pushed a commit that referenced this pull request May 5, 2026
PR-URL: #62663
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 7, 2026
PR-URL: #62663
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.