assert,util: fix stale nested cycle memo entries#62509
Merged
nodejs-github-bot merged 1 commit intoApr 9, 2026
nodejs:mainnodejs/node:mainfrom
BridgeAR:BridgeAR/2026-03-29-fix-comparisonBridgeAR/node:BridgeAR/2026-03-29-fix-comparisonCopy head branch name to clipboard
Merged
assert,util: fix stale nested cycle memo entries#62509nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom BridgeAR:BridgeAR/2026-03-29-fix-comparisonBridgeAR/node:BridgeAR/2026-03-29-fix-comparisonCopy head branch name to clipboard
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
BridgeAR:BridgeAR/2026-03-29-fix-comparisonBridgeAR/node:BridgeAR/2026-03-29-fix-comparisonCopy head branch name to clipboard
Conversation
Temporary nested cycle-tracking entries could remain in the memory set after a successful comparison. If a later sibling comparison reused one of those objects, deepStrictEqual could incorrectly fail for equivalent structures. This cleans up the temporary nested entries after the nested comparison returns. Fixes: nodejs#62422
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62509 +/- ##
==========================================
- Coverage 89.77% 89.71% -0.07%
==========================================
Files 673 692 +19
Lines 203840 214043 +10203
Branches 39180 41058 +1878
==========================================
+ Hits 182998 192024 +9026
- Misses 13156 14095 +939
- Partials 7686 7924 +238
🚀 New features to boost your workflow:
|
ljharb
approved these changes
Mar 30, 2026
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
|
Landed in 8db9d43 |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
Temporary nested cycle-tracking entries could remain in the memory set after a successful comparison. If a later sibling comparison reused one of those objects, deepStrictEqual could incorrectly fail for equivalent structures. This cleans up the temporary nested entries after the nested comparison returns. Fixes: #62422 PR-URL: #62509 Fixes: #62422 Reviewed-By: Jordan Harband <ljharb@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 7, 2026
Temporary nested cycle-tracking entries could remain in the memory set after a successful comparison. If a later sibling comparison reused one of those objects, deepStrictEqual could incorrectly fail for equivalent structures. This cleans up the temporary nested entries after the nested comparison returns. Fixes: #62422 PR-URL: #62509 Fixes: #62422 Reviewed-By: Jordan Harband <ljharb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary nested cycle-tracking entries could remain in the memory set after a successful comparison. If a later sibling comparison reused one of those objects, deepStrictEqual could incorrectly fail for equivalent structures.
This cleans up the temporary nested entries after the nested comparison returns.
Fixes: #62422