Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

deps: update nghttp2 to 1.68.1#62381

Closed
nodejs-github-bot wants to merge 1 commit into
mainnodejs/node:mainfrom
actions/tools-update-nghttp2nodejs/node:actions/tools-update-nghttp2Copy head branch name to clipboard
Closed

deps: update nghttp2 to 1.68.1#62381
nodejs-github-bot wants to merge 1 commit into
mainnodejs/node:mainfrom
actions/tools-update-nghttp2nodejs/node:actions/tools-update-nghttp2Copy head branch name to clipboard

Conversation

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

This is an automated update of nghttp2 to 1.68.1.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Mar 22, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/http2
  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Mar 22, 2026
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-nghttp2 branch from b92a238 to 0b14648 Compare March 29, 2026 00:56
@pimterry pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-nghttp2 branch from 326292c to 4a520cd Compare April 5, 2026 00:57
@trivikr

trivikr commented Apr 5, 2026

Copy link
Copy Markdown
Member

This requires reverting a change was causes CI failures

Example revert in previous PR: 1ab2794

@mcollina

mcollina commented Apr 5, 2026

Copy link
Copy Markdown
Member

@trivikr I'm lost.

@trivikr

trivikr commented Apr 5, 2026

Copy link
Copy Markdown
Member

The commit nghttp2/nghttp2@7784fa9 published in nghttp@1.67.0 have been breaking CI tests in Node.js

Antoine documented it in #60661, and we've been reverting that commit when upgrading nghttp2.
An example revert from previous PR 1ab2794

@pimterry

pimterry commented Apr 8, 2026

Copy link
Copy Markdown
Member

I'm going to look into the upstream nghttp2 issue here and see if I can find a proper solution, watch this space.

EDIT: See nghttp2/nghttp2#2604 (comment)

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-nghttp2 branch from 4a520cd to 125cac6 Compare April 12, 2026 00:59
@mcollina

Copy link
Copy Markdown
Member

Unless those can be fixed/reverted upstream, we would have to update the test.

@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-nghttp2 branch from 125cac6 to 41c1b65 Compare April 19, 2026 01:01
@Kangie

Kangie commented Apr 19, 2026

Copy link
Copy Markdown

The commit nghttp2/nghttp2@7784fa9 published in nghttp@1.67.0 have been breaking CI tests in Node.js

Antoine documented it in #60661, and we've been reverting that commit when upgrading nghttp2. An example revert from previous PR 1ab2794

This is unreasonable on downstreams using unbundled nghttp2. Please just fix the code here - your tests are failing for a reason.

@pimterry

Copy link
Copy Markdown
Member

This is unreasonable on downstreams using unbundled nghttp2. Please just fix the code here - your tests are failing for a reason.

Hi @Kangie - I appreciate the input and challenges here, but that's not so simple. This is an actual incompatibility that creates breaking changes in Node.js http2 when using nghttp2 1.67 & 1.68. I'm not sure how you can best manage this in unbundled environments, but we can't include unexpected breaking changes like that in official releases.

Fortunately, there's been more discussion in nghttp2/nghttp2#2604, and the key nghttp2 changes have now been reverted in 1.69. For some other remaining changes we'll still need updates here in Node.js to release, but more limited in scope.

nghttp2 1.69.0 was just released yesterday with this, I'm aiming to test & integrate that today or tomorrow to resolve this and open a new PR. I'll update here once there's progress.

@pimterry

Copy link
Copy Markdown
Member

I've opened a new PR with an update to 1.69.0 and the corresponding fixes required: #62867. I'll close this now since that replaces this bump.

@pimterry pimterry closed this Apr 21, 2026
@aduh95 aduh95 deleted the actions/tools-update-nghttp2 branch April 21, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.