Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

tools: enable eslint concurrency mode#62352

Open
JLHwung wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
JLHwung:improve-eslint-ci-perfJLHwung/node:improve-eslint-ci-perfCopy head branch name to clipboard
Open

tools: enable eslint concurrency mode#62352
JLHwung wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
JLHwung:improve-eslint-ci-perfJLHwung/node:improve-eslint-ci-perfCopy head branch name to clipboard

Conversation

@JLHwung

@JLHwung JLHwung commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

In this PR we enable the ESLint --concurrency mode. Per report from TIME(1), a cache-missed eslint job has improved from 75 seconds to 25 seconds on my machine. In the cache-hit scenario, both mode exit in less than 2 seconds.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 20, 2026
@anonrig

anonrig commented Mar 20, 2026

Copy link
Copy Markdown
Member

We also bumped all eslint deps. Linter is still happy, no code changes are required.

Can you open a different pull-request for this?

@codecov

codecov Bot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (7547e79) to head (7831d51).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62352      +/-   ##
==========================================
- Coverage   91.60%   89.69%   -1.91%     
==========================================
  Files         337      676     +339     
  Lines      140745   206693   +65948     
  Branches    21802    39584   +17782     
==========================================
+ Hits       128925   185389   +56464     
- Misses      11595    13442    +1847     
- Partials      225     7862    +7637     

see 461 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JLHwung

JLHwung commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

We also bumped all eslint deps. Linter is still happy, no code changes are required.

Can you open a different pull-request for this?

Sure, open #62356.

@anonrig

anonrig commented Mar 20, 2026

Copy link
Copy Markdown
Member

Can you update this PR?

@JLHwung JLHwung force-pushed the improve-eslint-ci-perf branch from 8255ac3 to 7831d51 Compare March 20, 2026 18:16
@JLHwung JLHwung changed the title tools: enable eslint concurrency mode and bump eslint deps tools: enable eslint concurrency mode Mar 20, 2026
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 26, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@JLHwung

JLHwung commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

It seems that CI errors are not related, could anyone restart the CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.