Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

deps: backport V8 simdutf utf8 length for two-byte strings#62349

Closed
mertcanaltin wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
mertcanaltin:mert/v8-backport-utf8length-simdutfmertcanaltin/node:mert/v8-backport-utf8length-simdutfCopy head branch name to clipboard
Closed

deps: backport V8 simdutf utf8 length for two-byte strings#62349
mertcanaltin wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
mertcanaltin:mert/v8-backport-utf8length-simdutfmertcanaltin/node:mert/v8-backport-utf8length-simdutfCopy head branch name to clipboard

Conversation

@mertcanaltin

@mertcanaltin mertcanaltin commented Mar 20, 2026

Copy link
Copy Markdown
Member

Backport upstream V8 utf8_length_from_utf16 for two-byte strings in Utf8LengthV2.

refs: #61601

@nodejs-github-bot

nodejs-github-bot commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 20, 2026
aduh95
aduh95 requested changes Mar 20, 2026
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see doc/contributing/maintaining/maintaining-V8.md

@aduh95 aduh95 added the performance Issues and PRs related to the performance of Node.js. label Mar 20, 2026
@Renegade334

Renegade334 commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@mertcanaltin for backporting v8/v8@b25cd62 to release lines, you'll need to use the process described at https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md#backporting-with-git-node-recommended, eg. for v25.x:

  1. checkout the repo on the v25.x-staging branch
  2. run git node v8 backport b25cd62c7ba2
  3. build and test
  4. open a PR against v25.x-staging

@mertcanaltin

mertcanaltin commented Mar 20, 2026

Copy link
Copy Markdown
Member Author

Thanks for infos, I will edit

@mertcanaltin mertcanaltin mentioned this pull request Mar 20, 2026
Merged
@mertcanaltin

mertcanaltin commented Mar 20, 2026

Copy link
Copy Markdown
Member Author

thanks again, I opened this pr #62354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 requested changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mertcanaltin @nodejs-github-bot @Renegade334 @aduh95
Morty Proxy This is a proxified and sanitized view of the page, visit original site.