doc: clarify diffieHellman.generateKeys recomputes same key#62205
Merged
nodejs-github-bot merged 1 commit intoApr 21, 2026
nodejs:mainnodejs/node:mainfrom
kovan:doc-dh-generatekeys-wordingkovan/node:doc-dh-generatekeys-wordingCopy head branch name to clipboard
Merged
doc: clarify diffieHellman.generateKeys recomputes same key#62205nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom kovan:doc-dh-generatekeys-wordingkovan/node:doc-dh-generatekeys-wordingCopy head branch name to clipboard
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
kovan:doc-dh-generatekeys-wordingkovan/node:doc-dh-generatekeys-wordingCopy head branch name to clipboard
Conversation
Clarify that calling generateKeys() after a private key has been set recomputes the same public key deterministically, rather than implying the public key changes. The public key is fully determined by the private key, so the result is identical unless the private key was changed via setPrivateKey(). Fixes: nodejs#56990 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Review requested:
|
lpinca
approved these changes
Mar 13, 2026
Collaborator
|
Landed in eb54e70 |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
Clarify that calling generateKeys() after a private key has been set recomputes the same public key deterministically, rather than implying the public key changes. The public key is fully determined by the private key, so the result is identical unless the private key was changed via setPrivateKey(). Fixes: #56990 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> PR-URL: #62205 Fixes: #56990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95
pushed a commit
that referenced
this pull request
May 7, 2026
Clarify that calling generateKeys() after a private key has been set recomputes the same public key deterministically, rather than implying the public key changes. The public key is fully determined by the private key, so the result is identical unless the private key was changed via setPrivateKey(). Fixes: #56990 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> PR-URL: #62205 Fixes: #56990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
araujogui
pushed a commit
to araujogui/node
that referenced
this pull request
May 26, 2026
Clarify that calling generateKeys() after a private key has been set recomputes the same public key deterministically, rather than implying the public key changes. The public key is fully determined by the private key, so the result is identical unless the private key was changed via setPrivateKey(). Fixes: nodejs#56990 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> PR-URL: nodejs#62205 Fixes: nodejs#56990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that calling
generateKeys()after a private key has beenset recomputes the same public key deterministically. The current
wording ("only updates the public key") implies the public key
changes, but since it is fully determined by the private key, the
result is identical unless the private key was changed via
setPrivateKey().Verified against
lib/internal/crypto/diffiehellman.js—dhGenerateKeys()callsthis[kHandle].generateKeys()which wrapsOpenSSL's
DH_generate_key(), which deterministically computesthe public key from the private key.
Fixes: #56990