Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

tools: lint new WPTRunner() paths for no duplicates#61618

Closed
panva wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
panva:wpt-lint-new-wpt-runnerpanva/node:wpt-lint-new-wpt-runnerCopy head branch name to clipboard
Closed

tools: lint new WPTRunner() paths for no duplicates#61618
panva wants to merge 1 commit into
nodejs:mainnodejs/node:mainfrom
panva:wpt-lint-new-wpt-runnerpanva/node:wpt-lint-new-wpt-runnerCopy head branch name to clipboard

Conversation

@panva

@panva panva commented Feb 1, 2026

Copy link
Copy Markdown
Member

A lint rule to prevent future issues of duplicate wpt tests

Refs: #61617
Refs: #61316 (comment)

Local result:

➜  node git:(main) ✗ make lint-js    
Running JS linter...

/node/test/wpt/test-webidl.js
  6:30  error  WPTRunner path 'webidl' overlaps with 'webidl/ecmascript-binding/es-exceptions' in /node/test/wpt/test-domexception.js. One path is a subset of the other, which would run the same tests multiple times  node-core/no-duplicate-wpt-runner-paths

✖ 1 problem (1 error, 0 warnings)

@panva panva requested a review from aduh95 February 1, 2026 16:14
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Feb 1, 2026
@panva

This comment was marked as outdated.

Sign in to view
@panva panva marked this pull request as ready for review February 4, 2026 10:35
@panva panva force-pushed the wpt-lint-new-wpt-runner branch from 0d1b013 to 48d2bfe Compare February 4, 2026 10:37
@codecov

codecov Bot commented Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.74%. Comparing base (7bd2fea) to head (48d2bfe).
⚠️ Report is 251 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61618      +/-   ##
==========================================
- Coverage   89.74%   89.74%   -0.01%     
==========================================
  Files         674      674              
  Lines      204360   204360              
  Branches    39270    39273       +3     
==========================================
- Hits       183409   183403       -6     
+ Misses      13260    13256       -4     
- Partials     7691     7701      +10

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva closed this Mar 11, 2026
@panva panva deleted the wpt-lint-new-wpt-runner branch March 20, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@panva @nodejs-github-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.