Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

src: allow empty --experimental-config-file#61610

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
marco-ippolito:default-config-jsonmarco-ippolito/node:default-config-jsonCopy head branch name to clipboard
Apr 16, 2026
Merged

src: allow empty --experimental-config-file#61610
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
marco-ippolito:default-config-jsonmarco-ippolito/node:default-config-jsonCopy head branch name to clipboard

Conversation

@marco-ippolito

Copy link
Copy Markdown
Member

This PR makes --experimental-config-file accept no arg.
When no arg is passed, it will default to node.config.json.
--experimental-default-config-file is just an alias of --experimental-config-file.
The reason for this change is so when stable we can just remove --experimental-default-config-file and rename --experimental-config-file to --config-file.
Users can execute node with node --config-file index.js or node --config-file=foo.json index.js.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 1, 2026
@marco-ippolito marco-ippolito force-pushed the default-config-json branch 2 times, most recently from 775234b to 9b00ced Compare February 1, 2026 09:36

@pmarchini pmarchini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2026
@marco-ippolito marco-ippolito added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 1, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Feb 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (3f52482) to head (4bf9c84).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/node.cc 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61610      +/-   ##
==========================================
- Coverage   91.55%   89.69%   -1.87%     
==========================================
  Files         356      706     +350     
  Lines      149601   218143   +68542     
  Branches    23395    41734   +18339     
==========================================
+ Hits       136967   195659   +58692     
- Misses      12371    14412    +2041     
- Partials      263     8072    +7809     
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 98.38% <100.00%> (+14.63%) ⬆️
lib/internal/test_runner/runner.js 93.67% <100.00%> (+0.31%) ⬆️
src/node_config_file.cc 83.73% <100.00%> (ø)
src/node_config_file.h 100.00% <100.00%> (ø)
src/node_options.cc 76.61% <100.00%> (ø)
src/node_options.h 98.00% <ø> (ø)
src/node.cc 76.90% <87.50%> (ø)

... and 465 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito force-pushed the default-config-json branch 4 times, most recently from 3dc9b42 to 2356e3a Compare February 1, 2026 14:35
Comment thread test/parallel/test-runner-flag-propagation.js
@marco-ippolito marco-ippolito force-pushed the default-config-json branch 3 times, most recently from bef68d1 to 5ce1d98 Compare April 15, 2026 10:48
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2026
@github-actions github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71151/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/24459748339

@marco-ippolito marco-ippolito removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 15, 2026
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2026
@github-actions github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71151/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/24461444173

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@marco-ippolito marco-ippolito removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2026
@nodejs-github-bot nodejs-github-bot merged commit 2071c44 into nodejs:main Apr 16, 2026
71 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 2071c44

aduh95 pushed a commit that referenced this pull request May 5, 2026
PR-URL: #61610
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 added a commit that referenced this pull request May 5, 2026
Notable changes:

buffer:
  * (SEMVER-MINOR) add `end` parameter (Robert Nagy) #62390
crypto:
  * (SEMVER-MINOR) accept key data in `crypto.diffieHellman()` and cleanup DH jobs (Filip Skokan) #62527
  * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) #62553
debugger:
  * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713
fs:
  * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) #57775
  * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277
http:
  * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) #63082
  * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) #62541
lib,src,test,doc:
  * (SEMVER-MINOR) add `node:ffi` module (Colin Ihrig) #62072
process:
  * (SEMVER-MINOR) throw on `execve(2)` failure instead of aborting (Bryan English) #62878
src:
  * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610
stream:
  * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) #61098
test_runner:
  * (SEMVER-MINOR) align mock timeout api (sangwook) #62820
  * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) #60751
  * (SEMVER-MINOR) support test order randomization (Pietro Marchini) #61747
util:
  * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) #61556

PR-URL: #63137
aduh95 added a commit that referenced this pull request May 6, 2026
Notable changes:

buffer:
  * (SEMVER-MINOR) add `end` parameter (Robert Nagy) #62390
crypto:
  * (SEMVER-MINOR) accept key data in `crypto.diffieHellman()` and cleanup DH jobs (Filip Skokan) #62527
  * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) #62553
debugger:
  * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713
fs:
  * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) #57775
  * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277
http:
  * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) #63082
  * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) #62541
lib,src,test,doc:
  * (SEMVER-MINOR) add `node:ffi` module (Colin Ihrig) #62072
process:
  * (SEMVER-MINOR) throw on `execve(2)` failure instead of aborting (Bryan English) #62878
src:
  * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610
stream:
  * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) #61098
test_runner:
  * (SEMVER-MINOR) align mock timeout api (sangwook) #62820
  * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) #60751
  * (SEMVER-MINOR) support test order randomization (Pietro Marchini) #61747
util:
  * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) #61556

PR-URL: #63137
aduh95 added a commit that referenced this pull request May 6, 2026
Notable changes:

buffer:
  * (SEMVER-MINOR) add `end` parameter (Robert Nagy) #62390
crypto:
  * (SEMVER-MINOR) accept key data in `crypto.diffieHellman()` and cleanup DH jobs (Filip Skokan) #62527
  * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) #62553
debugger:
  * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713
fs:
  * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) #57775
  * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277
http:
  * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) #63082
  * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) #62541
lib,src,test,doc:
  * (SEMVER-MINOR) add `node:ffi` module (Colin Ihrig) #62072
process:
  * (SEMVER-MINOR) throw on `execve(2)` failure instead of aborting (Bryan English) #62878
src:
  * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610
stream:
  * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) #61098
test_runner:
  * (SEMVER-MINOR) align mock timeout api (sangwook) #62820
  * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) #60751
  * (SEMVER-MINOR) support test order randomization (Pietro Marchini) #61747
util:
  * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) #61556

PR-URL: #63137
aduh95 added a commit that referenced this pull request May 7, 2026
Notable changes:

buffer:
  * (SEMVER-MINOR) add `end` parameter (Robert Nagy) #62390
crypto:
  * (SEMVER-MINOR) accept key data in `crypto.diffieHellman()` and cleanup DH jobs (Filip Skokan) #62527
  * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) #62553
debugger:
  * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713
fs:
  * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) #57775
  * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277
http:
  * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) #63082
  * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) #62541
lib,src,test,doc:
  * (SEMVER-MINOR) add `node:ffi` module (Colin Ihrig) #62072
process:
  * (SEMVER-MINOR) throw on `execve(2)` failure instead of aborting (Bryan English) #62878
src:
  * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610
stream:
  * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) #61098
test_runner:
  * (SEMVER-MINOR) align mock timeout api (sangwook) #62820
  * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) #60751
  * (SEMVER-MINOR) support test order randomization (Pietro Marchini) #61747
util:
  * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) #61556

PR-URL: #63137
const result = await spawnPromisified(process.execPath, [
'--experimental-config-file',
'i-do-not-exist.json',
'--experimental-config-file=i-do-not-exist.json',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really get this change, is it an unrelated no-op? It's making the change not land cleanly on v24.x-staging, should I simply forgo those?

araujogui pushed a commit to araujogui/node that referenced this pull request May 26, 2026
PR-URL: nodejs#61610
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
araujogui pushed a commit to araujogui/node that referenced this pull request May 26, 2026
Notable changes:

buffer:
  * (SEMVER-MINOR) add `end` parameter (Robert Nagy) nodejs#62390
crypto:
  * (SEMVER-MINOR) accept key data in `crypto.diffieHellman()` and cleanup DH jobs (Filip Skokan) nodejs#62527
  * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) nodejs#62553
debugger:
  * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) nodejs#62713
fs:
  * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) nodejs#57775
  * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) nodejs#62277
http:
  * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) nodejs#63082
  * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) nodejs#62541
lib,src,test,doc:
  * (SEMVER-MINOR) add `node:ffi` module (Colin Ihrig) nodejs#62072
process:
  * (SEMVER-MINOR) throw on `execve(2)` failure instead of aborting (Bryan English) nodejs#62878
src:
  * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) nodejs#61610
stream:
  * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) nodejs#61098
test_runner:
  * (SEMVER-MINOR) align mock timeout api (sangwook) nodejs#62820
  * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) nodejs#60751
  * (SEMVER-MINOR) support test order randomization (Pietro Marchini) nodejs#61747
util:
  * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) nodejs#61556

PR-URL: nodejs#63137
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request May 30, 2026
PR-URL: nodejs#61610
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.