Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

sea: print error information when fs operations fail#61581

Closed
joyeecheung wants to merge 2 commits into
nodejs:mainnodejs/node:mainfrom
joyeecheung:sea-err-codejoyeecheung/node:sea-err-codeCopy head branch name to clipboard
Closed

sea: print error information when fs operations fail#61581
joyeecheung wants to merge 2 commits into
nodejs:mainnodejs/node:mainfrom
joyeecheung:sea-err-codejoyeecheung/node:sea-err-codeCopy head branch name to clipboard

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: #61579

@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Jan 29, 2026
richardlau
richardlau approved these changes Jan 29, 2026
View reviewed changes

@richardlau richardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this testable (e.g. passing a non-existent binary in the config?)?

@codecov

codecov Bot commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.76%. Comparing base (68d7b6f) to head (905a22e).
⚠️ Report is 448 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sea_bin.cc 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61581      +/-   ##
==========================================
- Coverage   89.77%   89.76%   -0.02%     
==========================================
  Files         673      673              
  Lines      203820   203864      +44     
  Branches    39175    39189      +14     
==========================================
+ Hits       182987   183006      +19     
- Misses      13152    13187      +35     
+ Partials     7681     7671      -10
Files with missing lines Coverage Δ
src/node_sea_bin.cc 41.72% <50.00%> (+0.12%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71133/

@nodejs-github-bot

nodejs-github-bot commented Jan 31, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71140/

@alexsch01

alexsch01 commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

This is a good change and also my issue is more to do with missing command prompt detection: #61579 (comment)

@joyeecheung joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Feb 2, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2026
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2026

Copy link
Copy Markdown
Collaborator

Landed in baba748...8e41b8d

nodejs-github-bot pushed a commit that referenced this pull request Feb 2, 2026
@joyeecheung @nodejs-github-bot
sea: print error information when fs operations fail
8e41b8d 
PR-URL: #61581
Refs: #61579
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@joyeecheung @aduh95
sea: print error information when fs operations fail
4a2e184 
PR-URL: #61581
Refs: #61579
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@aduh95 aduh95 mentioned this pull request Feb 2, 2026
Merged
himself65 added a commit to himself65/node that referenced this pull request Mar 10, 2026
@himself65
sea: print error information when fs operations fail
6e75c4b 
PR-URL: nodejs#61581
Refs: nodejs#61579
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@himself65 himself65 mentioned this pull request Mar 10, 2026
Open
himself65 added a commit to himself65/node that referenced this pull request Mar 10, 2026
@himself65
sea: print error information when fs operations fail
b43c8ec 
PR-URL: nodejs#61581
Refs: nodejs#61579
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
himself65 pushed a commit to himself65/node that referenced this pull request Mar 10, 2026
@joyeecheung @himself65
sea: print error information when fs operations fail
d6e7b10 
PR-URL: nodejs#61581
Refs: nodejs#61579
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@aduh95 aduh95 added the backport-open-v24.x Indicate that the PR has an open backport label Apr 3, 2026
aduh95 pushed a commit to himself65/node that referenced this pull request Apr 5, 2026
@joyeecheung @aduh95
sea: print error information when fs operations fail
2ceec88 
PR-URL: nodejs#61581
Refs: nodejs#61579
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

+1 more reviewer

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-open-v24.x Indicate that the PR has an open backport commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@joyeecheung @nodejs-github-bot @alexsch01 @lpinca @UlisesGascon @richardlau @legendecas @aymen94 @aduh95
Morty Proxy This is a proxified and sanitized view of the page, visit original site.