Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

module: do not wrap module._load when tracing is not enabled#61479

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
joyeecheung:module-load-framejoyeecheung/node:module-load-frameCopy head branch name to clipboard
Jan 26, 2026
Merged

module: do not wrap module._load when tracing is not enabled#61479
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
joyeecheung:module-load-framejoyeecheung/node:module-load-frameCopy head branch name to clipboard

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Jan 22, 2026

Copy link
Copy Markdown
Member

This prevents clobbering the stack traces with another internal frame and removes the unnecessary hoops from step-debugging.

@joyeecheung
module: do not wrap module._load when tracing is not enabled
e06bcd0 
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jan 22, 2026
@codecov

codecov Bot commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.87%. Comparing base (e9b0849) to head (e06bcd0).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61479      +/-   ##
==========================================
- Coverage   91.93%   89.87%   -2.06%     
==========================================
  Files         343      665     +322     
  Lines      139636   203296   +63660     
  Branches    22026    39081   +17055     
==========================================
+ Hits       128369   182713   +54344     
- Misses      11040    12929    +1889     
- Partials      227     7654    +7427
Files with missing lines Coverage Δ
lib/internal/modules/cjs/loader.js 98.16% <100.00%> (+18.70%) ⬆️

... and 453 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina
mcollina approved these changes Jan 22, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70978/

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70980/

@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70985/

@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70988/

@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71027/

@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71035/

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 26, 2026
@nodejs-github-bot nodejs-github-bot merged commit 644ba1f into nodejs:main Jan 26, 2026
79 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

Landed in 644ba1f

aduh95 pushed a commit that referenced this pull request Jan 28, 2026
@joyeecheung @aduh95
module: do not wrap module._load when tracing is not enabled
a28ddd4 
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.

PR-URL: #61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@github-actions github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
@joyeecheung @aduh95
module: do not wrap module._load when tracing is not enabled
3cbd36a 
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.

PR-URL: #61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@github-actions github-actions Bot mentioned this pull request Feb 22, 2026
Merged
@glenjamin glenjamin mentioned this pull request Feb 22, 2026
Closed
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
@joyeecheung @aduh95
module: do not wrap module._load when tracing is not enabled
8d7190b 
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.

PR-URL: #61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
joyeecheung added a commit to joyeecheung/node that referenced this pull request Feb 25, 2026
@joyeecheung
module: do not wrap module._load when tracing is not enabled
832476e 
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.

PR-URL: nodejs#61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
joyeecheung added a commit to joyeecheung/node that referenced this pull request Feb 25, 2026
@joyeecheung
module: do not wrap module._load when tracing is not enabled
8cf1d34 
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.

PR-URL: nodejs#61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
joyeecheung added a commit to joyeecheung/node that referenced this pull request Feb 27, 2026
@joyeecheung
module: do not wrap module._load when tracing is not enabled
6df0cdf 
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.

PR-URL: nodejs#61479
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@joyeecheung joyeecheung mentioned this pull request Feb 27, 2026
Closed
marco-ippolito pushed a commit that referenced this pull request Apr 27, 2026
@joyeecheung @marco-ippolito
module: do not wrap module._load when tracing is not enabled
9a2e213 
This prevents clobbering the stack traces with another internal
frame and removes the unnecessary hoops from step-debugging.

PR-URL: #61479
Backport-PR-URL: #62029
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Fixes: #61801
@marco-ippolito marco-ippolito mentioned this pull request May 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Qard Qard Qard approved these changes

@lpinca lpinca lpinca approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joyeecheung @nodejs-github-bot @mcollina @Qard @lpinca @marco-ippolito
Morty Proxy This is a proxified and sanitized view of the page, visit original site.