Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@narqo
Copy link

@narqo narqo commented Apr 6, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added 馃槃
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc

@narqo narqo changed the title Fix a typo in 5.10.1's changelog doc: fix a typo in 5.10.1's changelog Apr 6, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Apr 6, 2016

LGTM

@r-52 r-52 added the doc Issues and PRs related to the documentations. label Apr 6, 2016
@r-52
Copy link
Contributor

r-52 commented Apr 6, 2016

LGTM

@MylesBorins
Copy link
Contributor

Lgtm

@jasnell
Copy link
Member

jasnell commented Apr 7, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 7, 2016
PR-URL: #6076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 7, 2016

Landed in 31524d7

@jasnell jasnell closed this Apr 7, 2016
MylesBorins pushed a commit that referenced this pull request Apr 7, 2016
PR-URL: #6076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

I've gone ahead and backported this to v5.x in 60a73a2

@narqo
Copy link
Author

narqo commented Apr 7, 2016

馃憤

This was referenced Apr 20, 2016
jasnell pushed a commit that referenced this pull request Apr 26, 2016
PR-URL: #6076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.