src: replace Environment::GetCurrent with args.GetIsolate #60256
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ba6485 to
a344fff
Compare
addaleax
approved these changes
Oct 14, 2025
theanarkh
approved these changes
Oct 14, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60256 +/- ##
==========================================
- Coverage 88.57% 88.55% -0.02%
==========================================
Files 704 704
Lines 208183 208184 +1
Branches 40015 40019 +4
==========================================
- Hits 184404 184364 -40
- Misses 15808 15859 +51
+ Partials 7971 7961 -10
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Oct 15, 2025
bengl
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code in
node_util.ccanduv.ccto remove unnecessary calls toEnvironment::GetCurrent(args). Instead, useargs.GetIsolate()andisolate->GetCurrentContext()where applicable to reduce extra lookups and improve readability.No functional change.