sqlite: make SQLTagStore.prototype.size a getter
#60246
Open
+46
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
cjihrig
approved these changes
Oct 13, 2025
dabca78 to
3142319
Compare
I'm already half-addressing them de facto with the main change, but these can be spun out if desired. Edit: Spun out the other doc changes. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60246 +/- ##
==========================================
- Coverage 88.56% 88.55% -0.02%
==========================================
Files 704 704
Lines 208146 208155 +9
Branches 40009 40027 +18
==========================================
- Hits 184354 184338 -16
- Misses 15814 15824 +10
- Partials 7978 7993 +15
🚀 New features to boost your workflow:
|
louwers
approved these changes
Oct 13, 2025
3142319 to
ff66727
Compare
Drive-by: make callback `args` parameter names consistent
ff66727 to
a2eaaa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As implemented,
.dband.capacityare getters, and.sizeis a callable method. There's no reason for this inconsistency, so change.sizeto a getter.Drive-by changes while making alterations to the class template: the
FunctionCallbackInfoparameter for SQLTagStore member functions was variably labelledargsorinfo, and wasn't consistent with the header either. Use the canonicalargs.