test,doc: skip --max-old-space-size-percentage on 32-bit platforms #60144
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Oct 7, 2025
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60144 +/- ##
==========================================
+ Coverage 88.52% 88.56% +0.03%
==========================================
Files 703 703
Lines 207997 207997
Branches 40024 40014 -10
==========================================
+ Hits 184134 184207 +73
+ Misses 15875 15809 -66
+ Partials 7988 7981 -7 🚀 New features to boost your workflow:
|
Contributor
Author
|
The tests fail due to flakiness |
lpinca
approved these changes
Oct 7, 2025
UlisesGascon
approved these changes
Oct 7, 2025
Collaborator
aymen94
approved these changes
Oct 8, 2025
cjihrig
approved these changes
Oct 8, 2025
Collaborator
Collaborator
Collaborator
Collaborator
|
Landed in ad2c1bf |
Asaf-Federman
added a commit
to Asaf-Federman/node
that referenced
this pull request
Oct 9, 2025
PR-URL: nodejs#60144 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Asaf-Federman
added a commit
to Asaf-Federman/node
that referenced
this pull request
Oct 9, 2025
PR-URL: nodejs#60144 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Asaf-Federman
added a commit
to Asaf-Federman/node
that referenced
this pull request
Oct 11, 2025
PR-URL: nodejs#60144 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 tasks
aduh95
pushed a commit
that referenced
this pull request
Oct 31, 2025
PR-URL: #60144 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 7, 2025
PR-URL: #60144 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request skip testing the --max-old-space-size-percentage flag on 32-bit platforms. The flag, which sets the maximum memory size of V8's old memory section as a percentage of available system memory, may cause integer overflow issues on 32-bit systems. The documentation have been updated to clarify its behavior and limitations on 32-bit systems.