Backport of #5778 #5960
Backport of #5778 #5960
Conversation
|
@Trott can you keep the original review data please 😄 |
|
Original review metadata restored. Guess you'll want to update the PR number, eh? I left it as the old one. Wasn't sure what your procedure is. Just pointing out in case I guessed wrong. |
|
I usually leave the old one so that everything sync's up with branch diff |
df3a543 to
7384140
Compare
|
@Trott .. looks like your branch needs to be rebased to clear out the extraneous commits here. |
|
@jasnell rebased and force pushed. There still seems to be one extraneous commit. ??? |
|
@Trott can you rebase out e42bd4a |
|
@thealphanerd OK, done! |
|
@Trott this commit is blowing up the linter. Look like there is still a whole bunch of non template literal string concatenation happening in v4.x... 236 errors in total. This amount of churn does make me a bit uneasy |
|
Yeah, I'd say let's hold off on this given that high number of failures. |
|
Heh, that's because I modified the wrong |
Convert string concatenation to template literals. Enforce with lint rule. PR-URL: nodejs#5778 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
OK! Linter passes now. Sheesh. Sorry about that. |
|
landed in 4f683ab |
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)
Description of change
Please provide a description of the change here.
Convert string concatenation to template literals. Enforce with lint
rule.