src: cleanup uv_fs_req before uv_fs_stat on existSync #58915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: https://hackerone.com/reports/3184178 Calling uv_fs_stat() without first calling uv_fs_req_cleanup() overwrites the pointer to the previously allocated buffer leading to a memory leak on windows
marco-ippolito
approved these changes
Jul 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58915 +/- ##
==========================================
- Coverage 90.11% 90.09% -0.02%
==========================================
Files 640 640
Lines 188427 188427
Branches 36956 36968 +12
==========================================
- Hits 169792 169756 -36
- Misses 11348 11385 +37
+ Partials 7287 7286 -1
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Jul 1, 2025
bnoordhuis
approved these changes
Jul 2, 2025
StefanStojanovic
approved these changes
Jul 2, 2025
Commit Queue failed- Loading data for nodejs/node/pull/58915 ✔ Done loading data for nodejs/node/pull/58915 ----------------------------------- PR info ------------------------------------ Title src: cleanup uv_fs_req before uv_fs_stat on existSync (#58915) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:cleanup-uv-fs-req -> nodejs:main Labels c++, fs, author ready, needs-ci Commits 1 - src: cleanup uv_fs_req before uv_fs_stat on existSync Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/58915 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58915 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 01 Jul 2025 13:12:05 GMT ✔ Approvals: 4 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58915#pullrequestreview-2975392479 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/58915#pullrequestreview-2977169190 ✔ - Ben Noordhuis (@bnoordhuis): https://github.com/nodejs/node/pull/58915#pullrequestreview-2977858752 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/58915#pullrequestreview-2979305416 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-07-01T17:27:03Z: https://ci.nodejs.org/job/node-test-pull-request/67773/ - Querying data for job/node-test-pull-request/67773/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16051447153 |
RafaelGSS
added a commit
that referenced
this pull request
Jul 3, 2025
Refs: https://hackerone.com/reports/3184178 Calling uv_fs_stat() without first calling uv_fs_req_cleanup() overwrites the pointer to the previously allocated buffer leading to a memory leak on windows PR-URL: #58915 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
|
Landed in aad9030 |
RafaelGSS
added a commit
that referenced
this pull request
Jul 8, 2025
Refs: https://hackerone.com/reports/3184178 Calling uv_fs_stat() without first calling uv_fs_req_cleanup() overwrites the pointer to the previously allocated buffer leading to a memory leak on windows PR-URL: #58915 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
Refs: https://hackerone.com/reports/3184178 Calling uv_fs_stat() without first calling uv_fs_req_cleanup() overwrites the pointer to the previously allocated buffer leading to a memory leak on windows PR-URL: #58915 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
Refs: https://hackerone.com/reports/3184178 Calling uv_fs_stat() without first calling uv_fs_req_cleanup() overwrites the pointer to the previously allocated buffer leading to a memory leak on windows PR-URL: #58915 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src: cleanup uv_fs_req before uv_fs_stat on existSync
cc: @bnoordhuis