Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

vassudanagunta
Copy link
Contributor

Existing links explaining the various target file-related run([options]) point to the wrong section.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem. labels Jun 28, 2025
doc/api/test.md Outdated Show resolved Hide resolved
vassudanagunta added a commit to vassudanagunta/node that referenced this pull request Jun 29, 2025
vassudanagunta added a commit to vassudanagunta/node that referenced this pull request Jun 29, 2025
@vassudanagunta
Copy link
Contributor Author

i forced pushed amended commits to comply with commit message rules. in doing so i excluded an unnecessary merge of main into this patch branch.

Links explaining the various target file-related `run([options])`
pointed to the wrong section.
@vassudanagunta
Copy link
Contributor Author

so sorry. i think i got the commit message right this time.

@JakobJingleheimer JakobJingleheimer added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 29, 2025
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 29, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2025
@nodejs-github-bot nodejs-github-bot merged commit 16035b4 into nodejs:main Jun 30, 2025
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 16035b4

targos pushed a commit that referenced this pull request Jul 3, 2025
Links explaining the various target file-related `run([options])`
pointed to the wrong section.

PR-URL: #58876
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
@vassudanagunta vassudanagunta deleted the patch-1 branch September 1, 2025 13:23
richardlau pushed a commit that referenced this pull request Sep 20, 2025
Links explaining the various target file-related `run([options])`
pointed to the wrong section.

PR-URL: #58876
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.