-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
test: replace .filter()[0]
with .find()
#58872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
LiviaMedeiros:test-filter0-find
Jun 29, 2025
Merged
test: replace .filter()[0]
with .find()
#58872
nodejs-github-bot
merged 1 commit into
nodejs:main
from
LiviaMedeiros:test-filter0-find
Jun 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58872 +/- ##
==========================================
+ Coverage 90.09% 90.10% +0.01%
==========================================
Files 640 640
Lines 188450 188450
Branches 36966 36964 -2
==========================================
+ Hits 169789 169812 +23
+ Misses 11364 11352 -12
+ Partials 7297 7286 -11 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Jun 28, 2025
aduh95
approved these changes
Jun 29, 2025
Landed in f6a4305 |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58872 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58872 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58872 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor adjustment.