doc: add missing comma in child_process.md
#58862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The git commit message does not follow our guidelines, an example of a valid commit message would be |
Adds a comma after "blocks" in a sentence explaining how subprocesses may pause when the pipe buffer is full. This improves readability and clarifies the meaning of the sentence, preventing misinterpretation of "blocks waiting" as a compound phrase. No functional code is affected.
ef49538 to
0682f79
Compare
child_process.md
0682f79 to
ce79106
Compare
aduh95
approved these changes
Jun 28, 2025
UlisesGascon
approved these changes
Jun 29, 2025
jasnell
approved these changes
Jun 29, 2025
|
Landed in bab36c3 |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
Adds a comma after "blocks" in a sentence explaining how subprocesses may pause when the pipe buffer is full. This improves readability and clarifies the meaning of the sentence, preventing misinterpretation of "blocks waiting" as a compound phrase. No functional code is affected. PR-URL: #58862 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
Adds a comma after "blocks" in a sentence explaining how subprocesses may pause when the pipe buffer is full. This improves readability and clarifies the meaning of the sentence, preventing misinterpretation of "blocks waiting" as a compound phrase. No functional code is affected. PR-URL: #58862 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
Adds a comma after "blocks" in a sentence explaining how subprocesses may pause when the pipe buffer is full. This improves readability and clarifies the meaning of the sentence, preventing misinterpretation of "blocks waiting" as a compound phrase. No functional code is affected. PR-URL: #58862 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc: add comma after "blocks" for clarity in child_process.md
This PR improves clarity in doc/api/child_process.md by adding a comma after the word "blocks" in the sentence:
The change improves readability and ensures proper grammatical flow. No functional code is affected.
No functional code is affected.