Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fs: close dir before throwing if options.bufferSize is invalid #58856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2025
Merged

fs: close dir before throwing if options.bufferSize is invalid #58856

merged 1 commit into from
Jul 6, 2025

Conversation

LiviaMedeiros
Copy link
Member

@LiviaMedeiros LiviaMedeiros commented Jun 26, 2025 •
edited
Loading

Fixes: #58854

Test blocked on: #58855

@LiviaMedeiros LiviaMedeiros added the blocked PRs that are blocked by other issues or PRs. label Jun 26, 2025
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 26, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (4d5ee24) to head (eadbae5).
Report is 45 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58856      +/-   ##
==========================================
- Coverage   90.10%   90.10%   -0.01%     
==========================================
  Files         640      640              
  Lines      188493   188499       +6     
  Branches    36971    36968       -3     
==========================================
+ Hits       169843   169848       +5     
- Misses      11358    11361       +3     
+ Partials     7292     7290       -2
Files with missing lines Coverage Δ
lib/internal/fs/dir.js 94.57% <100.00%> (+0.08%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros force-pushed the fs-dir-close-on-invalid-buffer branch from 2155c48 to 67ea569 Compare June 29, 2025 05:53
@LiviaMedeiros LiviaMedeiros removed the blocked PRs that are blocked by other issues or PRs. label Jun 29, 2025
@LiviaMedeiros LiviaMedeiros force-pushed the fs-dir-close-on-invalid-buffer branch from 67ea569 to eadbae5 Compare June 29, 2025 05:57
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67717/

@juanarbol juanarbol added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 6, 2025
@nodejs-github-bot nodejs-github-bot merged commit 9ab9763 into nodejs:main Jul 6, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9ab9763

RafaelGSS pushed a commit that referenced this pull request Jul 8, 2025
@LiviaMedeiros @RafaelGSS
fs: close dir before throwing if options.bufferSize is invalid
b378fc3 
PR-URL: #58856
Fixes: #58854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@LiviaMedeiros @aduh95
fs: close dir before throwing if options.bufferSize is invalid
fb8b85a 
PR-URL: #58856
Fixes: #58854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@LiviaMedeiros @aduh95
fs: close dir before throwing if options.bufferSize is invalid
c7ebf2e 
PR-URL: #58856
Fixes: #58854
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs: opendirSync() leaks directory handle on error

5 participants

@LiviaMedeiros @nodejs-github-bot @jasnell @lpinca @juanarbol
Morty Proxy This is a proxified and sanitized view of the page, visit original site.