Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

dns: set timeout to 1000ms when timeout <= 0 #58441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

dns: set timeout to 1000ms when timeout <= 0 #58441

merged 1 commit into from
Jun 25, 2025

Conversation

theanarkh
Copy link
Contributor

c-ares set timeout to DEFAULT_TIMEOUT(2000ms) When timeout is <= 0, so we should schedule timer every 1000ms.

if (optmask & ARES_OPT_TIMEOUTMS) {
    /* Apparently some integrations were passing -1 to tell c-ares to use
     * the default instead of just omitting the optmask */
    if (options->timeout <= 0) {
      optmask &= ~(ARES_OPT_TIMEOUTMS);
    } else {
      channel->timeout = (unsigned int)options->timeout;
    }
}

if (channel->timeout == 0) {
  channel->timeout = DEFAULT_TIMEOUT;
}

cc @jasnell

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels May 23, 2025
@theanarkh theanarkh force-pushed the optimize_dns_timeout_with_0 branch from 47e17b5 to 1a25e88 Compare May 23, 2025 19:54
@theanarkh theanarkh changed the title dns: set timeout to 1000ms when timeout < 0 dns: set timeout to 1000ms when timeout <= 0 May 23, 2025
@codecov Codecov
Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (cd68e35) to head (1a25e88).
Report is 228 commits behind head on main.

Files with missing lines Patch % Lines
src/cares_wrap.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58441      +/-   ##
==========================================
- Coverage   90.19%   90.19%   -0.01%     
==========================================
  Files         635      635              
  Lines      187224   187223       -1     
  Branches    36765    36763       -2     
==========================================
- Hits       168876   168867       -9     
- Misses      11131    11133       +2     
- Partials     7217     7223       +6
Files with missing lines Coverage Δ
src/cares_wrap.cc 54.35% <0.00%> (-0.04%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67066/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67074/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67084/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67147/

@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2025
@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2025
@nodejs-github-bot nodejs-github-bot merged commit f08e0a0 into nodejs:main Jun 25, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f08e0a0

targos pushed a commit that referenced this pull request Jul 3, 2025
@theanarkh @targos
dns: set timeout to 1000ms when timeout < 0
f40ac32 
PR-URL: #58441
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@theanarkh @aduh95
dns: set timeout to 1000ms when timeout < 0
0e6737a 
PR-URL: #58441
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@theanarkh @aduh95
dns: set timeout to 1000ms when timeout < 0
e8f4a7d 
PR-URL: #58441
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 18, 2025
@theanarkh @marco-ippolito
dns: set timeout to 1000ms when timeout < 0
9cef756 
PR-URL: #58441
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Aug 20, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Aug 20, 2025
@theanarkh @marco-ippolito
dns: set timeout to 1000ms when timeout < 0
7dbfeb5 
PR-URL: #58441
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@juanarbol juanarbol juanarbol approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theanarkh @nodejs-github-bot @jasnell @juanarbol @jakecastelli
Morty Proxy This is a proxified and sanitized view of the page, visit original site.