Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

test: fix flaky debugger test#58324

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
islandryu:fix/debuggerTestislandryu/node:fix/debuggerTestCopy head branch name to clipboard
Jan 27, 2026
Merged

test: fix flaky debugger test#58324
nodejs-github-bot merged 1 commit into
nodejs:mainnodejs/node:mainfrom
islandryu:fix/debuggerTestislandryu/node:fix/debuggerTestCopy head branch name to clipboard

Conversation

@islandryu

@islandryu islandryu commented May 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

For some reason, I’ve lost Jenkins permissions and can’t post the detailed URL, but I’m modifying the contents of this CI:
https://ci.nodejs.org/job/node-test-commit/79774/

I encountered this on my Windows machine when running this command.

 python3 tools/test.py --repeat=10000 parallel/test-debugger-break

node/test/parallel/test-debugger-break.js

Lines 37 to 44 in b197355

await cli.stepCommand('next');
assert.ok(
cli.output.includes(`step in ${script}:3`),
'pauses in next line of the script');
assert.match(
cli.output,
/> 3 name = 'Robin';/,
'marks the 3nd line');

The cause was the output of the cont command.
Normally, it looks like this

< Hello Robin
< 
break in test/fixtures/debugger/break.js:10
  8 }
  9 sayHello();
>10 debugger;
 11 setTimeout(sayHello, 10);
 12 
debug>

However, on rare occasions, the order of the debugger output and standard output is reversed like this:

break in test/fixtures/debugger/break.js:10
  8 }
  9 sayHello();
>10 debugger;
 11 setTimeout(sayHello, 10);
 12 
debug> 
< Hello Robin
< 
debug>

So I modified it to wait for the corresponding response before proceeding to the next command.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 14, 2025
@codecov

codecov Bot commented May 14, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.23%. Comparing base (4edb139) to head (bd1f167).
⚠️ Report is 1727 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58324      +/-   ##
==========================================
- Coverage   90.24%   90.23%   -0.01%     
==========================================
  Files         633      633              
  Lines      186860   186860              
  Branches    36675    36679       +4     
==========================================
- Hits       168623   168622       -1     
- Misses      11035    11042       +7     
+ Partials     7202     7196       -6

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@islandryu islandryu mentioned this pull request May 15, 2025
Merged
@ShogunPanda ShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2025
@nodejs-github-bot

nodejs-github-bot commented May 15, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66799/

@nodejs-github-bot

nodejs-github-bot commented May 15, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66820/

@islandryu

islandryu commented May 27, 2025

Copy link
Copy Markdown
Member Author

@ShogunPanda @lpinca @StefanStojanovic
The failure is just due to another flaky test, so could you please rerun the tests?

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2025
@nodejs-github-bot

nodejs-github-bot commented May 27, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67148/

@nodejs-github-bot

nodejs-github-bot commented May 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67163/

@islandryu islandryu added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 26, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71045/

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71055/

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71056/

@islandryu islandryu added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 27, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 27, 2026
@nodejs-github-bot nodejs-github-bot merged commit 720feff into nodejs:main Jan 27, 2026
69 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

Landed in 720feff

aduh95 pushed a commit that referenced this pull request Jan 28, 2026
@islandryu @aduh95
test: fix flaky debugger test
945b141 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actions github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 3, 2026
@islandryu @aduh95
test: fix flaky debugger test
4381f88 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Feb 3, 2026
@islandryu @aduh95
test: fix flaky debugger test
1c32b22 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actions github-actions Bot mentioned this pull request Feb 3, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 6, 2026
@islandryu @aduh95
test: fix flaky debugger test
f511c24 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
@islandryu @aduh95
test: fix flaky debugger test
9688f16 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
@islandryu @aduh95
test: fix flaky debugger test
e998aa3 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
@islandryu @aduh95
test: fix flaky debugger test
0c6159a 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
@islandryu @aduh95
test: fix flaky debugger test
a767578 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@aduh95 aduh95 mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
@islandryu @aduh95
test: fix flaky debugger test
e6fb809 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Feb 24, 2026
@islandryu @aduh95
test: fix flaky debugger test
f604b7a 
PR-URL: #58324
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@islandryu @nodejs-github-bot @lpinca @StefanStojanovic @ShogunPanda
Morty Proxy This is a proxified and sanitized view of the page, visit original site.