doc: add puskin to collaborators #58308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-ippolito
approved these changes
May 13, 2025
Contributor
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
Contributor
|
Fast-track has been requested by @puskin. Please 👍 to approve. |
pmarchini
approved these changes
May 13, 2025
aduh95
reviewed
May 13, 2025
| Gerhard Stöbich <deb2001-github@yahoo.de> | ||
| Gibson Fahnestock <gibfahn@gmail.com> <gib@uk.ibm.com> | ||
| Gil Pedersen <git@gpost.dk> <github@gpost.dk> | ||
| Giovanni Bucci <github@puskin.it> |
Contributor
There was a problem hiding this comment.
Out of curiosity, why this addition?
Member
There was a problem hiding this comment.
Otherwise the find-inactive tool was flagging it. I think there is a mismatch between emails
Contributor
There was a problem hiding this comment.
Ah right, it must the name that mismatches (commit author is Giovanni <github@puskin.it>, while the tool is looking for Giovanni Bucci <github@puskin.it>)
Contributor
Author
There was a problem hiding this comment.
it is part of this doc: https://github.com/nodejs/node/blob/main/onboarding.md#exercise-make-a-pull-request-adding-yourself-to-the-readme .
It says:
Run tools/find-inactive-collaborators.mjs. If that command outputs your name, amend the commit to include an addition to the [mailmap](https://github.com/nodejs/node/blob/main/.mailmap) file. See [gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the format of the mailmap file.
aduh95
approved these changes
May 13, 2025
Collaborator
|
Landed in e8c06a5 |
nodejs-github-bot
added a commit
that referenced
this pull request
May 20, 2025
Notable changes: doc: * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 fs: * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 test_runner: * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202 PR-URL: #58406
aduh95
pushed a commit
that referenced
this pull request
May 21, 2025
Notable changes: doc: * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 fs: * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 test_runner: * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202 PR-URL: #58406
nodejs-github-bot
added a commit
that referenced
this pull request
Jun 10, 2025
Notable changes: assert: * (SEMVER-MINOR) mark partialDeepStrictEqual() as stable (Ruben Bridgewater) #57370 doc: * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * mark multiple APIs stable (James M Snell) #57513 fs: * (SEMVER-MINOR) add autoClose option to FileHandle readableWebStream (James M Snell) #58548 * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 src,permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 PR-URL: #58665
aduh95
pushed a commit
that referenced
this pull request
Jun 23, 2025
Notable changes: assert: * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370 doc: * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * mark multiple APIs stable (James M Snell) #57513 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 http2: * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 src,permission: * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579 util: * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437 PR-URL: #58665
aduh95
pushed a commit
that referenced
this pull request
Jun 24, 2025
Notable changes: assert: * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370 doc: * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * mark multiple APIs stable (James M Snell) #57513 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 http2: * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 src,permission: * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579 util: * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437 PR-URL: #58665
aduh95
pushed a commit
that referenced
this pull request
Jun 25, 2025
Notable changes: assert: * (SEMVER-MINOR) mark `partialDeepStrictEqual()` as stable (Ruben Bridgewater) #57370 doc: * deprecate instantiating `node:http` classes without new (Yagiz Nizipli) #58518 * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * mark multiple APIs stable (James M Snell) #57513 fs: * (SEMVER-MINOR) add `autoClose` option to `FileHandle` `readableWebStream` (James M Snell) #58548 * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 http2: * (SEMVER-MINOR) add diagnostics channel `http2.server.stream.finish` (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 src,permission: * implicit `allow-fs-read` to app entrypoint (Rafael Gonzaga) #58579 util: * (SEMVER-MINOR) add `'none'` style to styleText (James M Snell) #58437 PR-URL: #58665
marco-ippolito
added a commit
that referenced
this pull request
Aug 20, 2025
Notable changes: doc: * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add @geeksilva97 to collaborators (Edy Silva) #57241 PR-URL: TODO
marco-ippolito
added a commit
that referenced
this pull request
Aug 20, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 23, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 25, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 25, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 25, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 25, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 26, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 26, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 27, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 27, 2025
marco-ippolito
added a commit
that referenced
this pull request
Aug 27, 2025
marco-ippolito
added a commit
that referenced
this pull request
Sep 2, 2025
marco-ippolito
added a commit
that referenced
this pull request
Sep 2, 2025
marco-ippolito
added a commit
that referenced
this pull request
Sep 3, 2025
marco-ippolito
added a commit
that referenced
this pull request
Sep 3, 2025
marco-ippolito
added a commit
that referenced
this pull request
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58088