Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@Trott
Copy link
Member

@Trott Trott commented Mar 10, 2016

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test, events

Description of change

Add test for known issue where a valid event name may be rejected.

Refs: #728

@Trott Trott added events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests. lts-watch-v4.x labels Mar 10, 2016
@mscdex mscdex mentioned this pull request Mar 11, 2016
4 tasks
@jasnell
Copy link
Member

jasnell commented Mar 11, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Mar 12, 2016

Closing, with permission, in favor of 10bc673

@cjihrig cjihrig closed this Mar 12, 2016
@Trott Trott deleted the proto-noto branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.